121449 - make single deletions possible from tree elements in Navigator|Languages, Mailnews|Send Format panels

Status: VERIFIED FIXED

(SeaMonkey :: Preferences, defect, P2)

Description

[racham]

Deleting tree elements is broken in the following windows.

1. Edit|Preferences|Navigator|Languages (languages set tree)
2. Edit|Mail&Newsgroups|Send Format (html & plain text domain trees) 
3. View|Character Coding|Customize (charset entries tree)

Add entries in any of the tree and then try to delete one or multiple. Error

JavaScript error:
chrome://messenger/content/messengercompose/pref-formatting.js line 180: row has
 no properties

will be encountered depending on where you are. The above is from
Mail&Newsgroups|Send Format panel.

All these files have a while loop to allow multiple selections which is broken
now due to the wrong values obtained from the tree widget. I will file a
separatebug to take care of the tree widget problem.

This bug is opened because, today, even if you try to delete a single element in
the tree, it fails to do that. So, there is no way to delete these entries other
than manually changing the prefs which is no solution. This is happening due the
fact that tree.selectedItems.length is returning the same value over and over
and tree widget is failing to return the correct value on the second iteration.

I have patch that allows us to fix single deletions until the original problem
is fixed. This patch will work just fine even after the original problem (will
file a bug and update this bug with that info) is fixed.

Comment 1

[racham]

Attachment: patch, v1.0 - Allow single selection deletions via a local variable for number of originallly items selected

Comment 2

[racham]

If there is a single-fix-all solution, please do post an updated patch OR let me
know and I will post an updated patch.

Comment 3

[racham]

Filed bug 121457 to address the core tree widget problem.

Comment 4

[Jean-Francois Ducarroz]

Comment on attachment 66132 [details] [diff] [review]
patch, v1.0 - Allow single selection deletions via a local variable for number of originallly items selected

please remove the line:
+      dump("length = " + obj.tree_node.selectedItems.length + "\n");

Appart that, R=ducarroz

Comment 5

[racham]

oops! That was my debug line. Will certainly take care (remove) it. thanks. 

Comment 6

[racham]

Attachment: patch, v1.2 - removed debug dump statement and unused variables

Comment 7

[Jean-Francois Ducarroz]

Comment on attachment 66631 [details] [diff] [review]
patch, v1.2 - removed debug dump statement  and unused variables

R=ducarroz

Comment 8

[(not reading, please use [e-mail] instead)]

Comment on attachment 66631 [details] [diff] [review]
patch, v1.2 - removed debug dump statement  and unused variables

sr=sspitzer

Comment 9

[(not reading, please use [e-mail] instead)]

please also get hewitt to look at this.  the fix looks similar in all three
places, so maybe he can think of a way to solve this in tree.xml

Comment 10

[racham]

Hewitt mentioned that he is working on patch to make these panels to use
listboxes in 099 milestone. All these problems should the go away.

Reassigning to Hewitt so that he can keep track of these (121449, 121457) bugs.

bhuvan

Comment 11

[Jaime Rodriguez, Jr.]

ADT3 per ADT/Nav triage.

Comment 12

[Joe Hewitt (gone)]

fixed

Comment 13

[sairuh (rarely reading bugmail)]

tested using 2002.04.09 comm bits on linux rh7.2, win2k and mac 10.1.3.

test #1 (prefs Navigator > Languages) works
test #2 (prefs Send Format) works
test #3 Customize char set *fails* --no js console info, though

should i reopen this bug, based on test #3 failing, or should i just spin off a
seperate bug for that? (am leaning towards the latter.)

Comment 14

[sairuh (rarely reading bugmail)]

vrfy'ing.

filed bug 137592 for the char coding case.