1214554 - Crash when using the geolocation api

Status: RESOLVED FIXED

(B2GDroid Graveyard :: General, defect)

Description

[Autumn.Qiu(Leave from Mozilla)]

Attachment: logcat_GPS.txt

[1.Description]:
If user tries to turn on GPS access for the application, device will crash in B2G Video app.
Found time: 10:25
See attcchment:AriesKK_v2.5_GPS.3gp & logcat_GPS.txt.

[2.Testing Steps]: 
1. Select the settings.
2. Turn Geolocation on, and hit the home button. 
3. Launch the web browser or use bookmark to go to http://maps.google.com.
4. Turn on GPS access for the application.
 
[3.Expected Result]: 
In step 4, The page should operate normally and share your position information.

[4.Actual Result]: 
In step 4, The browser will crash.

[5.Reproduction build]: 
Android version: 4.4.4(Build Number 23.0.A.2.93)
B2GDroid version: 0.11

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
9564

[8.NOTE]
This function is works normal on latest build of flame v2.5 & aries v2.5

Comment 1

[Autumn.Qiu(Leave from Mozilla)]

Attachment: AriesKK_v2.5_GPS.3gp

Comment 2

[Autumn.Qiu(Leave from Mozilla)]

(In reply to Autumn.Qiu from comment #0) 
> [1.Description]:
> If user tries to turn on GPS access for the application, device will crash
> in B2G Video app.

Sorry, modify the description in comment 0 to: If user tries to turn on GPS access for the application, device will crash.

Comment 3

[[:fabrice] Fabrice Desré]

I was able to reproduce, we crash with:

E/GeckoCrashHandler(14794): java.lang.NullPointerException: Attempt to invoke interface method 'void android.location.LocationListener.onLocationChanged(android.location.Location)' on a null object reference
E/GeckoCrashHandler(14794): 	at org.mozilla.gecko.GeckoAppShell$4.run(GeckoAppShell.java:522)
E/GeckoCrashHandler(14794): 	at android.os.Handler.handleCallback(Handler.java:739)
E/GeckoCrashHandler(14794): 	at android.os.Handler.dispatchMessage(Handler.java:95)
E/GeckoCrashHandler(14794): 	at android.os.Looper.loop(Looper.java:211)
E/GeckoCrashHandler(14794): 	at android.app.ActivityThread.main(ActivityThread.java:5321)
E/GeckoCrashHandler(14794): 	at java.lang.reflect.Method.invoke(Native Method)
E/GeckoCrashHandler(14794): 	at java.lang.reflect.Method.invoke(Method.java:372)
E/GeckoCrashHandler(14794): 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1016)
E/GeckoCrashHandler(14794): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:811)

Comment 4

[[:fabrice] Fabrice Desré]

Attachment: geoloc.patch

This implements a basic GeckoInterface for Launcher.java in order to provide the LocationListener implementation.

Comment 5

[Reuben Morais [:reuben]]

Comment on attachment 8682095 [details] [diff] [review]
geoloc.patch

Review of attachment 8682095 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/4cb0e2f32f8f

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4cb0e2f32f8f

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/4cb0e2f32f8f