1214569 - [User Story] Unpin page from pin dialog

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

Comment 1

[Alison Shiue]

Hi Ben,

This user story should be the last feature of 2.5 not yet landed, right?
Is bug 1168970 still 2.5+ for feature-b2g?

Comment 2

[Ben Francis [:benfrancis]]

Correct, this was a late feature request and we can live without it but nice to have.

Bug 1168970 is still 2.5+, the work was done in bug 1202571 so I've resolved it FIXED :)

Comment 3

[Alison Shiue]

Hi Ben,

Good to know that we only have one unfinished feature remains!
I think this user story is very important. Without it, the inconsistent display on pin dialog (eg, still show "pin" button when navigates to a already pinned page/site) would make user feel confused.
Thus, can we make this user story as 2.5+ for feature-b2g?

Comment 4

[Ben Francis [:benfrancis]]

This was a late feature request and wasn't part of the MVP but would be nice to have.

Because we can't yet rearrange pinned pages on the homescreen it's actually quite handy to be able to re-pin a page to bring it to the top of the list.

We will aim to fix this for 2.5 but it shouldn't block the release.

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] gmarty:Bug-1214569-Unpin-page-from-pin-dialog > mozilla-b2g:master

Comment 6

[Guillaume Marty [:gmarty]]

Comment on attachment 8676332 [details] [review]
[gaia] gmarty:Bug-1214569-Unpin-page-from-pin-dialog > mozilla-b2g:master

Hey, Alberto, what do you think of this patch?

Comment 7

[Alberto Pastor [:albertopq]]

Comment on attachment 8676332 [details] [review]
[gaia] gmarty:Bug-1214569-Unpin-page-from-pin-dialog > mozilla-b2g:master

Styling comment in GH (feel free to don't fix it if you disagree). r=me with a nice UI test that covers unpining a page :). We'll cover all the cases after that!

Thanks!

Comment 8

[Guillaume Marty [:gmarty]]

Landed in https://github.com/mozilla-b2g/gaia/commit/7d9543a86ee7ad6b9e8e5e01a8aa0ce152519627