Closed Bug 1214590 Opened 6 years ago Closed 6 years ago

Stop assigning room names default titles

Categories

(Hello (Loop) :: Client, defect, P2)

defect

Tracking

(firefox45 fixed)

RESOLVED FIXED
mozilla45
Iteration:
44.3 - Nov 2
Tracking Status
firefox45 --- fixed

People

(Reporter: standard8, Assigned: dcritchley)

References

Details

(Whiteboard: [web sharing])

User Story

Acceptance Criteria:

- When a room is created, it is no longer given a room name.
- The previous strings and code for the default room name are removed

Attachments

(1 file, 1 obsolete file)

As part of the user journey rework, we should stop assigning default titles to room names. This depends on bug 1214582 so that we displaying at least one title all the time.

See the user story for more detail.
Rank: 16
Assignee: nobody → david.critchley
Remove Loop default Room name
Attachment #8680942 - Flags: review?(dmose)
Comment on attachment 8680942 [details] [diff] [review]
Attachment to Bug 1214590 - Stop assigning room names default titles

Review of attachment 8680942 [details] [diff] [review]:
-----------------------------------------------------------------

Modulo a couple of nits, which I'll fix before I land, this looks good.  Right now I'm fighting with the mochitest infrastructure on stuff that I suspect is unrelated, but is nonetheless getting in the way of me landing this. r=dmose

::: browser/components/loop/content/js/panel.jsx
@@ -440,5 @@
>          "room-entry": true,
>          "room-active": this._isActive(),
>          "room-opened": this.props.isOpenedRoom
>        });
> -

Might as well leave this as is.

::: browser/components/loop/content/js/roomStore.js
@@ +267,5 @@
>        this._notifications.remove("create-room-error");
> +      if ("urls" in actionData && actionData.urls[0].description === "fakeSite42") {
> +        console.log("Action Data: ", actionData);
> +        console.log("Room Creation Data: ", roomCreationData);
> +        console.log("----------------------------------------------------------------------------------------");

These console.logs wanna go.
Attachment #8680942 - Flags: review?(dmose) → review+
With review nits fixed.
Attachment #8681431 - Flags: review+
Attachment #8680942 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/375a22f7bc4e
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion
Iteration: --- → 44.3 - Nov 2
You need to log in before you can comment on or make changes to this bug.