Closed Bug 1214626 Opened 4 years ago Closed 4 years ago

Gradle build: Update mediarouter dependency

Categories

(Firefox Build System :: Android Studio and Gradle Integration, defect)

All
Android
defect
Not set

Tracking

(firefox44 fixed)

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: sebastian, Assigned: batmanav10, Mentored)

Details

(Whiteboard: [good first bug])

Attachments

(1 file)

I just saw that we are still using mediarouter 22.2.1 in our gradle builds:

https://dxr.mozilla.org/mozilla-central/source/mobile/android/gradle/base/build.gradle#78

The mach based build uses 23.0.1.
Hey,

I've made the suggested change but haven't tried the gradle build yet.

Please review this patch.

Thanks.
Attachment #8676424 - Flags: review?(s.kaspari)
Assignee: nobody → batmanav10
Status: NEW → ASSIGNED
Comment on attachment 8676424 [details] [diff] [review]
Updated mediarouter dependency in gradle build

Review of attachment 8676424 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Manav!

I tested the patch locally and it works without issues. In fact we have been using mediarouter 23.0.1 in mach based builds for some time already:
https://dxr.mozilla.org/mozilla-central/source/build/autoconf/android.m4#335
Attachment #8676424 - Flags: review?(s.kaspari) → review+
This just touches the gradle build we use in IntelliJ / Android Studio and does not touch the regular mach based build. So I'm adding "checkin-needed" without triggering a try run.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/0b816b4edef0
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
(In reply to Sebastian Kaspari (:sebastian) from comment #3)
> This just touches the gradle build we use in IntelliJ / Android Studio and
> does not touch the regular mach based build. So I'm adding "checkin-needed"
> without triggering a try run.

If it doesn't need to run in automation, you can also add "DONTBUILD NPOTB" to the commit message.  I like that on the second line, beneath the summary.
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 44 → mozilla44
You need to log in before you can comment on or make changes to this bug.