1214626 - Gradle build: Update mediarouter dependency

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

I just saw that we are still using mediarouter 22.2.1 in our gradle builds:

https://dxr.mozilla.org/mozilla-central/source/mobile/android/gradle/base/build.gradle#78

The mach based build uses 23.0.1.

Comment 1

[Manav Batra]

Attachment: Updated mediarouter dependency in gradle build

Hey,

I've made the suggested change but haven't tried the gradle build yet.

Please review this patch.

Thanks.

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8676424 [details] [diff] [review]
Updated mediarouter dependency in gradle build

Review of attachment 8676424 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Manav!

I tested the patch locally and it works without issues. In fact we have been using mediarouter 23.0.1 in mach based builds for some time already:
https://dxr.mozilla.org/mozilla-central/source/build/autoconf/android.m4#335

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

This just touches the gradle build we use in IntelliJ / Android Studio and does not touch the regular mach based build. So I'm adding "checkin-needed" without triggering a try run.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/0b816b4edef0

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0b816b4edef0

Comment 6

[Nick Alexander :nalexander [he/him]]

(In reply to Sebastian Kaspari (:sebastian) from comment #3)
> This just touches the gradle build we use in IntelliJ / Android Studio and
> does not touch the regular mach based build. So I'm adding "checkin-needed"
> without triggering a try run.

If it doesn't need to run in automation, you can also add "DONTBUILD NPOTB" to the commit message.  I like that on the second line, beneath the summary.