Closed
Bug 1214630
Opened 9 years ago
Closed 9 years ago
Rename 'tabContentStart' attribute of TabMenuStripLayout
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox44 fixed)
RESOLVED
FIXED
Firefox 44
| Tracking | Status | |
|---|---|---|
| firefox44 | --- | fixed |
People
(Reporter: sebastian, Assigned: sebastian)
References
Details
Attachments
(1 file)
|
3.59 KB,
patch
|
mcomella
:
review+
|
Details | Diff | Splinter Review |
Our TabMenuStripLayout supports defining a tabContentStart like TabLayout from the android design support library.
This conflict prevents us from adding the design support library:
> /Users/sebastian/Projects/Mozilla/fx-team/objdir-frontend/mobile/android/gradle/base/src/main/res/values/search_colors.xml:2 : Attribute "tabContentStart" has already been defined
We should rename the attribute (attrs.xml). Eventually we want to switch to TabLayout anyways (bug 1210371).
|
Assignee | |
Comment 1•9 years ago
|
||
This patch renames tabContentStart to tabMarginLeft. This is the best I can come up with right now.
Attachment #8673725 -
Flags: review?(michael.l.comella)
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → s.kaspari
Status: NEW → ASSIGNED
Attachment #8673725 -
Flags: review?(michael.l.comella) → review+
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•