1214878 - Plugin is not hidden during async scrolling, lags instead

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Botond Ballo [:botond]]

STR:
  1. Load http://telewizjarepublika.pl/szumlewicz-korwin-chce-dogadac-sie-z-pis-tylko-zjednoczona-lewica-jest-antysystemowa,24842.html
  2. Scroll down until you see the Flash video just above the comments
  3. Make sure you're running recent Nightly with APZ enabled, or
     enable APZ manually (layers.async-pan-zoom.enabled=true).
  3. Scroll up and down and observe the video.

The video's position lags behind as you scroll. I would have expected bug 1137944 to fix this by hiding the plugin during an async scroll.

Comment 1

[Botond Ballo [:botond]]

Jim, would you expect the fix in bug 1137944 to apply to this case, or is there something special about this page?

Comment 2

[Jim Mathies [:jimm]]

Hmm, yeah this should get hidden. Something must be going wrong with our scroll tracking in the content process in nsGfxScrollFrame I guess. I'll take a look.

Comment 3

[Jim Mathies [:jimm]]

Ah this plugin is embedded in an iframe, bet that has something to do with it.

Comment 4

[Jim Mathies [:jimm]]

Attachment: patch

Need to walk sub documents as well.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8674425 [details] [diff] [review]
patch

Review of attachment 8674425 [details] [diff] [review]:
-----------------------------------------------------------------

Oops. needs a test :-)

Comment 6

[Jim Mathies [:jimm]]

Attachment: tests

good idea. carbon copies of the original scroll tests with a sub frame plugin.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/59588063362c
https://hg.mozilla.org/integration/mozilla-inbound/rev/eddce960bab6

Comment 8

[Jim Mathies [:jimm]]

Is is possible that we might have an iframe within an iframe that has a plugin? If so, I think I need to add yet another layer to this where I walk subframes, and then try to walk subframes within each sub frame, and so on down the tree.

Comment 9

[Jim Mathies [:jimm]]

Hmm, we don't do this in nsPresShell, so maybe EnumerateSubDocuments picks up all sub documents. I can't tell from the nsIDocument header. I'll test once this work gets out to mc.

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/59588063362c
https://hg.mozilla.org/mozilla-central/rev/eddce960bab6

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/59588063362c
https://hg.mozilla.org/mozilla-central/rev/eddce960bab6

Comment 12

[2ljpswpih]

@ Carsten, should it look like this? I've sent you an e-mail with video of this bug.

Comment 13

[Carsten Book [:Tomcat]]

(In reply to to_du from comment #12)
> @ Carsten, should it look like this? I've sent you an e-mail with video of
> this bug.

Hi, i'm not the initial developer who wrote the fix so i can't say (i only checked in the patch to the central repo). Jim is the developer who worked on this fix, redirecting the needinfo to him

Comment 14

[2ljpswpih]

Can you send this video to Jim?

Comment 15

[Carsten Book [:Tomcat]]

maybe it would be more useful to attach it here ?

Comment 16

[Jim Mathies [:jimm]]

I'm not sure what's being discussed, is this bug 1212813? If so attach it there. New regressions related to the work here (hiding plugins in subframes while scrolling) should be filed individually.

Comment 17

[2ljpswpih]

https://youtu.be/dWhFiQOufnw

Comment 18

[Botond Ballo [:botond]]

(In reply to to_du from comment #17)
> https://youtu.be/dWhFiQOufnw

This is not just bug 1212813; the video is only partially redrawn when scrolling stops. Please file a new bug for this.

Comment 19

[2ljpswpih]

https://bugzilla.mozilla.org/show_bug.cgi?id=1217168