1214939 - Black Material check in Android 4* password dialog

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Screenshot of the issue

It's strange because Gecko*DialogBase inherits from Holo styles – I'm guessing this doesn't inherit from that.

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Michael Comella (:mcomella) from comment #0)
> It's strange because Gecko*DialogBase inherits from Holo styles – I'm
> guessing this doesn't inherit from that.

But the EditText actually has Holo styles. :)

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

44+ for now to follow Theme.AppCompat but I feel this is lower priority than the other regressions and bugs I'm working on.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

We found out these are not being inflated correctly in bug 1220196 so we explicitly used the AppCompatCheckBox. It appears this one is inflated in code, so we should also explicitly use the AppCompatCheckBox. However, unlike the other bug, this is not likely to be a work around because I don't think AppCompat dynamically injects `AppCompatCheckBox`es in code, like it does in xml.

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1214939 - Explicitly use AppCompatCheckBox in PromptInput. r=sebastian

Bug 1214939 - Explicitly use AppCompatCheckBox in PromptInput. r=sebastian

This way it inherits from the AppCompat styles like accentColor.

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8681539 [details]
MozReview Request: Bug 1214939 - Explicitly use AppCompatCheckBox in PromptInput. r=sebastian

https://reviewboard.mozilla.org/r/23853/#review21345

Nice and simple. :)

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/af1868f1fc78a8aa6e3c8d694b07ba723563c827
Bug 1214939 - Explicitly use AppCompatCheckBox in PromptInput. r=sebastian

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/af1868f1fc78

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/af1868f1fc78