Closed Bug 1215033 Opened 9 years ago Closed 9 years ago

(Gaia RTL 2.5) CSS refactoring: keyboard

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Keyboard
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-master fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
b2g-master --- fixed

People

(Reporter: autra, Assigned: autra)

References

Details

Attachments

(1 file)

[gaia] Phoxygen:bug1215033-keyboard_rtl_refacto > mozilla-b2g:master
46 bytes, text/x-github-pull-request
timdream
: review+
Details | Review 
This bug is for the CSS refactoring of the keyboard application.

Only the "settings" view is to be mirrored.
Blocks: CSS_Refactor_2.5
Assignee: nobody → augustin.trancart
Comment on attachment 8676073 [details] [review]
[gaia] Phoxygen:bug1215033-keyboard_rtl_refacto > mozilla-b2g:master

Hi Tim,

Here is the CSS refactoring of the settings view of the keyboard app.

Please r?
Attachment #8676073 - Flags: review?(timdream)
Comment on attachment 8676073 [details] [review]
[gaia] Phoxygen:bug1215033-keyboard_rtl_refacto > mozilla-b2g:master

The code looks fine. I didn't manually test this.
Attachment #8676073 - Flags: review?(timdream) → review+
Thanks ! I'm waiting for the test to finish to check this in.
Keywords: checkin-needed
Status: NEW → ASSIGNED
On master: https://github.com/mozilla-b2g/gaia/commit/c220d2f40c52adb72823f209d0e12a61e32b735b
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-b2g-master: --- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: