This should give us a snappier single step more.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.0
That should read, "single step mode." I should convert the ephemeral lists at the same time, as described in bug 121318.
patch coming up for the JSDScript issue. bug 126983 filed re: ephemeral lists.
Created attachment 70705 [details] [diff] [review] patch, round one This patch adds a JSHashTable *scriptsTable member to JSDContext. The PRCList of scripts is still maintined to support iteration. AFAIK, it's a Bad Thing to modify a hash table while enumerating it, and that's exactly what would happen if the enumeration callback caused a new script to be created. Like, if it called through XPConnect to a function which used eval(). Ready for reviews, looking for 1.0 checkin.
I've already put the JS_ASSERT(JSD_SCRIPTS_LOCKED(jsdc)); call back in jsd_FindJSDScript.
Rob. This seems like a fine idea to me. I see you've included these changes in the patches for the profiler bug. Do you want to just get it in there or do separate review here or what?
If you just want to review it all as one patch in the profiler bug that sounds fine with me. It's probably easier for all of us. Profiling is now targeted at 0.9.9, BTW. Thanks for the help.
Fix went in as part of bug 109652
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.