1215050 - [LayerScope] Get crash while connecting with layerscope when using HWC

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jerry Shih[:jerry] (UTC+8) (inactive)]

If we only have few layer, b2g will try to use hwc for compositing. In this case, we got crash with layerscope tool.
The problem is that we don't handle the effectChain for TiledContentHost with single tile.

Comment 1

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: Make layerscope support TiledPaintedLayer when using HWC. v1

Fix the effect problem for "single tile" paintedLayer.

Comment 2

[u459114]

Comment on attachment 8674217 [details] [diff] [review]
Make layerscope support TiledPaintedLayer when using HWC. v1

Review of attachment 8674217 [details] [diff] [review]:
-----------------------------------------------------------------

In LayerScope::DrawEnd, find a way to skip sending DebugGLDrawData, since you do not setup draw rect in this path.
if (gLayerScopeManager.CurrentSession().mLayerRects.Length() > 0) {
    DrawSession& draws = gLayerScopeManager.CurrentSession();
    gLayerScopeManager.GetSocketManager()->AppendDebugData(
        new DebugGLDrawData(draws.mOffsetX, draws.mOffsetY,
                            draws.mMVMatrix, draws.mRects,
                            draws.mLayerRects,
                            draws.mTextureRects,
                            draws.mTexIDs,
                            aEffectChain.mLayerRef));
}

And, please double confirm visual result on the draw view of layerscope viewer.

Comment 3

[Jerry Shih[:jerry] (UTC+8) (inactive)]

(In reply to C.J. Ku[:cjku] from comment #2)
> Comment on attachment 8674217 [details] [diff] [review]
> Make layerscope support TiledPaintedLayer when using HWC. v1
> 
> Review of attachment 8674217 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> In LayerScope::DrawEnd, find a way to skip sending DebugGLDrawData, since
> you do not setup draw rect in this path.
> if (gLayerScopeManager.CurrentSession().mLayerRects.Length() > 0) {
>     DrawSession& draws = gLayerScopeManager.CurrentSession();
>     gLayerScopeManager.GetSocketManager()->AppendDebugData(
>         new DebugGLDrawData(draws.mOffsetX, draws.mOffsetY,
>                             draws.mMVMatrix, draws.mRects,
>                             draws.mLayerRects,
>                             draws.mTextureRects,
>                             draws.mTexIDs,
>                             aEffectChain.mLayerRef));
> }
> 
> And, please double confirm visual result on the draw view of layerscope
> viewer.

Since it's hard to get the right texture rects, I just send the default DrawData. The draw view will not see this hwc layer data. We could handle this problem at another bug.

Comment 4

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Please land the attachment 8674217 [details] [diff] [review] to m-c.

try link:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=df7fbdbaeb65

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5d0670128cb8

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5d0670128cb8