1215085 - [Wayland] - Enable EGL on Linux

Status: RESOLVED DUPLICATE of bug 1433081

(Core :: Graphics, enhancement, P3)

Description

[Martin Stránský [:stransky] (ni? me)]

+++ This bug was initially created as a clone of Bug #635134 +++

AFAIK GLX can't work on non-X11 displays so we need to disable it there.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: patch

Again, I wonder who is a correct reviewer here.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8674189 [details] [diff] [review]
patch

Review of attachment 8674189 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/GLContextProviderGLX.cpp
@@ +79,5 @@
> +        mGLXMinorVersion = 0;
> +        return false;
> +    }
> +#endif
> +

It feels like this should be avoided by not trying initialize GLContextProviderGLX instead of having it fail.

Comment 3

[Jeff Muizelaar [:jrmuizel]]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #2)
> Comment on attachment 8674189 [details] [diff] [review]
> patch
> 
> Review of attachment 8674189 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: gfx/gl/GLContextProviderGLX.cpp
> @@ +79,5 @@
> > +        mGLXMinorVersion = 0;
> > +        return false;
> > +    }
> > +#endif
> > +
> 
> It feels like this should be avoided by not trying initialize
> GLContextProviderGLX instead of having it fail.

Is Wayland something we know at build time, or are we supposed to support running both X and Wayland with same binary?

Comment 4

[Martin Stránský [:stransky] (ni? me)]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #3)
> Is Wayland something we know at build time, or are we supposed to support
> running both X and Wayland with same binary?

It's just a different Gtk backend and it's switched at run time. It's possible to build for Wayland only but IMHO better to support both (and other possible non-X11 backends) in one binary.

Comment 5

[Martin Stránský [:stransky] (ni? me)]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #2)
> Comment on attachment 8674189 [details] [diff] [review]
> patch
> 
> Review of attachment 8674189 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: gfx/gl/GLContextProviderGLX.cpp
> @@ +79,5 @@
> > +        mGLXMinorVersion = 0;
> > +        return false;
> > +    }
> > +#endif
> > +
> 
> It feels like this should be avoided by not trying initialize
> GLContextProviderGLX instead of having it fail.

What's the best way to do that? Fail in GLContextProviderGLX::GetGlobalContext?

Comment 6

[Jeff Muizelaar [:jrmuizel]]

So this brings up a bit of an issue. We currently only support a single GLContextProvider type per build (i.e. GLX or EGL). For now, I'd suggest switching the wayland builds to a build time configuration and moving them to use the GLContextProviderEGL.

Do you know what the recommended way of dealing with GLX vs EGL with GTK is supposed to be?

Comment 7

[Martin Stránský [:stransky] (ni? me)]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #6)
> Do you know what the recommended way of dealing with GLX vs EGL with GTK is
> supposed to be?

I asked Gtk guys and they don't have any clear recommendation here. Also the build-time configuration looks impractical - GL would be only reason to have extra binary for X11 and for Wayland.

Comment 8

[Martin Stránský [:stransky] (ni? me)]

According to Bug 788319 we should use EGL everywhere. Unfortunately the --with-gl-providel=EGL param does not work right now.

Comment 10

[Florian Bender]

(In reply to Martin Stránský from comment #8)
> According to Bug 788319 we should use EGL everywhere. Unfortunately the
> --with-gl-providel=EGL param does not work right now.

Is this still true? What's the plan for this bug now? Bug 788319 confused me a bit here.

Comment 11

[Martin Stránský [:stransky] (ni? me)]

Attachment: EGL build patch

This patch allows to build trunk with --with-gl-providel=EGL and it actually works (at least with Wayland) when sandbox is weakened - it tries to load gl libraries which is disabled by sandbox right now.

Comment 13

[Martin Stránský [:stransky] (ni? me)]

Let's fix that at Bug 1433081