Closed
Bug 1215088
Opened 9 years ago
Closed 8 years ago
[Wayland] - Disable SHM there
Categories
(Core :: Widget: Gtk, enhancement)
Tracking
()
RESOLVED
DUPLICATE
of bug 1215104
Tracking | Status | |
---|---|---|
firefox44 | --- | affected |
People
(Reporter: stransky, Unassigned)
References
(Depends on 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
553 bytes,
patch
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #635134 +++ AFAIK SHM is not supported on Wayland so we need to disable it there.
Reporter | ||
Comment 1•9 years ago
|
||
Disable the SHM on Wayland.
Attachment #8674202 -
Flags: review?(karlt)
Comment 2•9 years ago
|
||
(In reply to Martin Stránský from comment #1) > Created attachment 8674202 [details] [diff] [review] > patch > > Disable the SHM on Wayland. How would this work, since on Wayland the fallback X surface path would also not be used, leaving no viable rendering paths at all? Wouldn't a lot more work be necessary to get this rendering on Wayland as it currently stands?
Reporter | ||
Comment 3•9 years ago
|
||
(In reply to Lee Salzman [:eihrul] from comment #2) > (In reply to Martin Stránský from comment #1) > > Created attachment 8674202 [details] [diff] [review] > > patch > > > > Disable the SHM on Wayland. > > How would this work, since on Wayland the fallback X surface path would also > not be used, leaving no viable rendering paths at all? > > Wouldn't a lot more work be necessary to get this rendering on Wayland as it > currently stands? See the working (but still WIP) version on https://github.com/stransky/gecko-dev there are all patches applied.
Reporter | ||
Comment 4•8 years ago
|
||
An updated patch for latest trunk.
Attachment #8674202 -
Attachment is obsolete: true
Attachment #8674202 -
Flags: review?(karlt)
Attachment #8763586 -
Flags: review?(karlt)
Comment 5•8 years ago
|
||
Comment on attachment 8763586 [details] [diff] [review] patch >+ if (!GDK_IS_X11_DISPLAY(mDisplay)) { >+ gShmAvailable = false; >+ return false; >+ } >+ > if (!XShmQueryExtension(mDisplay)) { > gShmAvailable = false; > return false; > } Please merge these two blocks into one by combining the tests with ||. r+ with the commit message of attachment 8674202 [details] [diff] [review].
Attachment #8763586 -
Flags: review?(karlt) → review+
Comment 6•8 years ago
|
||
Comment on attachment 8763586 [details] [diff] [review] patch Not required with attachment 8764160 [details] [diff] [review].
Attachment #8763586 -
Flags: review+
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•