1215088 - [Wayland] - Disable SHM there

Status: RESOLVED DUPLICATE of bug 1215104

(Core :: Widget: Gtk, enhancement)

Description

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

+++ This bug was initially created as a clone of Bug #635134 +++

AFAIK SHM is not supported on Wayland so we need to disable it there.

Comment 1

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Attachment: patch

Disable the SHM on Wayland.

Comment 2

[Lee Salzman [:lsalzman]]

(In reply to Martin Stránský from comment #1)
> Created attachment 8674202 [details] [diff] [review]
> patch
> 
> Disable the SHM on Wayland.

How would this work, since on Wayland the fallback X surface path would also not be used, leaving no viable rendering paths at all?

Wouldn't a lot more work be necessary to get this rendering on Wayland as it currently stands?

Comment 3

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

(In reply to Lee Salzman [:eihrul] from comment #2)
> (In reply to Martin Stránský from comment #1)
> > Created attachment 8674202 [details] [diff] [review]
> > patch
> > 
> > Disable the SHM on Wayland.
> 
> How would this work, since on Wayland the fallback X surface path would also
> not be used, leaving no viable rendering paths at all?
> 
> Wouldn't a lot more work be necessary to get this rendering on Wayland as it
> currently stands?

See the working (but still WIP) version on https://github.com/stransky/gecko-dev there are all patches applied.

Comment 4

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Attachment: patch

An updated patch for latest trunk.

Comment 5

[Karl Tomlinson (:karlt)]

Comment on attachment 8763586 [details] [diff] [review]
patch

>+  if (!GDK_IS_X11_DISPLAY(mDisplay)) {
>+    gShmAvailable = false;
>+    return false;
>+  }
>+
>   if (!XShmQueryExtension(mDisplay)) {
>     gShmAvailable = false;
>     return false;
>   }

Please merge these two blocks into one by combining the tests with ||.
r+ with the commit message of attachment 8674202 [details] [diff] [review].

Comment 6

[Karl Tomlinson (:karlt)]

Comment on attachment 8763586 [details] [diff] [review]
patch

Not required with attachment 8764160 [details] [diff] [review].