Closed Bug 1215107 Opened 9 years ago Closed 9 years ago

Add a link between manual classification and autoclassification

Categories

(Tree Management :: Treeherder, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jgraham, Assigned: jgraham)

References

Details

Attachments

(1 file)

47 bytes, text/x-github-pull-request
mdoglio
: review+
Details | Review
In particular: * When a job is manually starred and it has exactly 1 failure that could be the target of an auoclassifier, add the failure line as an autoclassification target. * When a job is autoclassified and has an equal number of bug suggestion lines and error summary lines, mark the overall job as classified by the autoclassifier
Attached file Pull Request
Will need more changes I expect, but let's make a start. I dumped a bunch of code on JobModel; maybe some of it should go elsewhere (I am never sure in this kind of setup where code that acts on the intersection between two models should live).
Attachment #8674229 - Flags: review?(mdoglio)
Comment on attachment 8674229 [details] [review] Pull Request I left some comments, please r? me again when ready.
Attachment #8674229 - Flags: review?(mdoglio)
Assignee: nobody → james
Attachment #8674229 - Flags: review?(mdoglio)
Attachment #8674229 - Flags: review?(mdoglio) → review+
Depends on: 1220445
Reverted in: https://github.com/mozilla/treeherder/commit/bc43f09637ac09e5c24d2760fd6408f147966e15 (Landing commit didn't appear in the bug since it needs a bug number in the commit message).
Depends on: 1221079
Fixed by bug 1252854
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Depends on: 1252854
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: