1215141 - adbhelper broken again with /adb-client.js, line 53: TypeError: invalid arguments

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[Alexandre Poirot [:ochameau] [PTO back August 21]]

JavaScript error: resource://gre/modules/commonjs/toolkit/loader.js -> resource://adbhelperatmozilla.org/adb-client.js, line 53: TypeError: invalid arguments

or

resource://adbhelperatmozilla.org/adb-client.js, line 37: TypeError: buffer is undefined

Comment 1

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Attachment: Pull request 23

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8674289 [details] [review]
Pull request 23

Works on latest Nightly and also in 42 before socket changes, thanks!

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Merged:

https://github.com/mozilla/adbhelper/commit/29f036956c22e7d4a39a073dc40544f08ec2b418

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

I also tested DE 43, which still uses the .buffer version from WebIDL (the API fix has not yet landed there).  So, it seems all cases are covered.

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

0.8.4 released.