1215199 - Draft email to be sent when Akismet check fails

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Editing, enhancement)

Description

[Justin Crawford [:hoosteeno] [:jcrawford]]

The spec for Akismet integration requires an email to go out when...
* Akismet fails to respond in a certain time or
* Akismet responds with an error

The email will go out to the spam watch list.

What should be in the email? This bug will be resolved by the answer.

Comment 1

[Jannis Leidel [:jezdez]]

FWIW, the email I've wrote up looks like this:

https://github.com/mozilla/kuma/pull/3482/files#diff-d251fd4742c12018ec5b4dbbad320cf8

Or when rendered it would look like this:

    * SPAM ATTEMPT *

    Title: Download this torrent now!!1!
    Slug: Web/HTML/HTML5
    Detected at: 2015-10-15 08:12:12

    Admin link: https://developer.mozilla.org/admin/wiki/documentspamattempt/123456

    * USER *

    Name: jezdez
    ID: 123456
    Joined at: 2011-01-01 10:00:01

    Profile link: https://developer.mozilla.org/en-US/profiles/jezdez
    Admin link: https://developer.mozilla.org/admin/users/user/123456

    * DOCUMENT *

    Title: HTML5
    Slug: Web/HTML/HTML5
    Language: en-US
    Last modified: 2015-10-15 08:12:11

    Site link: https://developer.mozilla.org/en-US/Web/HTML/HTML5
    Admin link: https://developer.mozilla.org/admin/wiki/document/123456

Does that suffice?

Comment 2

[Eric Shepherd [:sheppy]]

I'm not certain that that stuff is ordered optimally, but I think we should for the most part go with it for now and we can iterate later once we know what it feels like to use it. Rearranging the text in an email is relatively trivial.

It would be nice, though, if you could add an indicator showing whether or not the spam is in a newly-created page or one that previously existed. Just adding "[NEW]" after the title even would do.

Also, please include the time zone by the timestamps for people like me who can never remember where our server is. :)

Comment 3

[Jean-Yves Perrier [:teoli]]

Jannis what will be the title of the e-mail?

Comment 4

[Jannis Leidel [:jezdez]]

:teoli the subject will be "[MDN] Wiki spam attempt recorded"

Comment 5

[Jannis Leidel [:jezdez]]

This has been merged via bug 1188029, but I'm going to leave this ticket open in case we decide to improve upon the current email as mentioned in past comments.

Comment 6

[John Whitlock [:jwhitlock]]

Eric's requests from comment 2 are:

1) Add the time zone to the dates
2) Indicate if the document was newly created or an update

I'll implement those so we can close this bug and start fresh with new suggestions.

Comment 7

[John Whitlock [:jwhitlock]]

PR 3813 [1] converts all times to UTC and displays them with "+00:00" to indicate that it is UTC.  If/when that is merged to master, the bug will be auto-updated.

The existing email template indicates if the document is new, with a "[NEW]" tag by the title, and "The spam attempt doesn't have a document attached" in the "* DOCUMENT *" section. For attempted changes to existing documents, there is no "[NEW]" tag, and the "* DOCUMENT *" section includes details about the document.

[1] https://github.com/mozilla/kuma/pull/3813

Comment 8

[MDN Team (:mdn-dev)]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/54655850d387bf1f98a230e47f0487aaab8bd46a
bug 1215199 - Remove unused template functions

https://github.com/mozilla/kuma/commit/f623258343bc7f9c464c8361a52ee89a2135dede
bug 1215199 - Display spam email dates in UTC

https://github.com/mozilla/kuma/commit/575e2e37592e07463c667782b5c0f33e3bdba9e7
bug 1215199 - Collapse whitespace in spam email

https://github.com/mozilla/kuma/commit/22efc0538be59df46f84b74c46dfe2a66eab0f2b
Merge pull request #3813 from mozilla/spam_email_1215199

bug 1215199 - Display dates in spam email in UTC

Comment 9

[John Whitlock [:jwhitlock]]

New spam template is in production. Closing as fixed.

Email for new document looks like:

* SPAM ATTEMPT *

Title: User:jwhitlock:spam_test [NEW]
Slug: User:jwhitlock:spam_test
Detected at: 2016-03-14 17:56:53.112985+00:00

Admin link: https://developer.allizom.org/admin/wiki/documentspamattempt/10/

* USER *

Name: viagra-test-123
ID: 297014
Joined at: 2016-03-14 17:54:46+00:00

Profile link: https://developer.allizom.org/en-US/profiles/viagra-test-123
Admin link: https://developer.allizom.org/admin/users/user/297014/

* DOCUMENT *

The spam attempt doesn't have a document attached