1215216 - Screen Reader tutorial audio plays every time the device is restarted.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Accessibility, defect, P3)

Description

[Martin Shuman [:Marty]]

Attachment: logcat-Screen-Reader-Restart.txt

Description:
About 15 seconds after device start-up, the "To enable screen reader..." audio message will play.  This occurs every time the user starts the device, after they have completed the FTU, regardless if the user has interacted with the device during that time frame.

Additionally, if the user actually is in the FTU, the screen reader message will loop, repeating itself, sometimes cutting itself off early.

Repro Steps:
1) Update a Aries to 20151015110122
2) From the Homescreen, long press the power button and restart the device.
3) Wait 15 seconds after the device has finished booting up.

Actual:
The Screen Reader audio tutorial will play every time the device is rebooted.

Expected:
The Screen Reader audio tutorial is only played automatically during the FTU.

Environmental Variables:
Device: Aries 2.5
Build ID: 20151015110122
Gaia: 40ae7c292a36156458c66712b4bd61ecbe69272a
Gecko: e193b4da0a8c1025aa76a403c64663ff1cd41709
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 44.0a1 (2.5)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Repro frequency: 8/8
See attached: Logcat

Comment 1

[Martin Shuman [:Marty]]

This issue DOES occur on the latest Flame 2.5 build.
The Screen Reader audio tutorial will play every time the device is rebooted.

Environmental Variables:
Device: Flame 2.5
BuildID: 20151015030226
Gaia: 40ae7c292a36156458c66712b4bd61ecbe69272a
Gecko: e193b4da0a8c1025aa76a403c64663ff1cd41709
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 44.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0


************************

This issue does NOT occur on yesterday's Aries 2.5 build.
The Screen Reader audio tutorial is only played automatically during the FTU.

Environmental Variables:
Device: Aries 2.5
BuildID: 20151014133333
Gaia: df7683e4f7329c567deb487d11317578c6930246
Gecko: c3c027f6070db795bc59ba57795b8e36fde2471b
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 44.0a1 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Comment 2

[Pi Wei Cheng [:piwei] (inactive)]

b2g-inbound regression window:

Last Working
Device: Flame 2.5
BuildID: 20151014180850
Gaia: 7d3874b4c1ac7769c4e69cd6994274f488fe9fc1
Gecko: a85f4bd943162a32ff0e4e7f246f718d7eb3d6e6
Version: 44.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

First Broken
Device: Flame 2.5
BuildID: 20151014183349
Gaia: 7a9f94fd8fe809424e6cd83a9dbc9af31a659872
Gecko: d2259a9634aa2d0b29f00231f7e822e73d9d553f
Version: 44.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Last Working Gaia First Broken Gecko - no repro
Gaia: 7d3874b4c1ac7769c4e69cd6994274f488fe9fc1
Gecko: d2259a9634aa2d0b29f00231f7e822e73d9d553f

Last Working Gecko First Broken Gaia - repro
Gaia: 7a9f94fd8fe809424e6cd83a9dbc9af31a659872
Gecko: a85f4bd943162a32ff0e4e7f246f718d7eb3d6e6

Gaia pushlog:
https://github.com/mozilla-b2g/gaia/compare/7d3874b4c1ac7769c4e69cd6994274f488fe9fc1...7a9f94fd8fe809424e6cd83a9dbc9af31a659872

Caused by changes made in Bug 1193587.

Comment 3

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Sam this issue seems to have been caused by bug 1193587.  Can you please take a look?

Comment 4

[Sam Foster [:sfoster] (he/him)]

Ah interesting, I had a note to file this as I ran into it a lot while testing late customization in the FTU. Turns out it was my fault? :)

Comment 5

[Sam Foster [:sfoster] (he/him)]

Ok, I have the culprit: https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/ftu_launcher.js#L40
Preparing a patch.

Comment 6

[Sam Foster [:sfoster] (he/him)]

As the FtuLauncher has an event prefix of 'ftu', when it completes its 'start', it publishes a 'ftustarted' event. Accessibility is listening for this event and confuses it with the event it is actually waiting for, which is a relayed IAC 'started' event from the FTU. So its just an event name overloading issue. I have a patch in th eworks.

Comment 7

[Yura Zenevich [:yzen] (please use "needinfo")]

(In reply to Sam Foster [:sfoster] from comment #6)
> As the FtuLauncher has an event prefix of 'ftu', when it completes its
> 'start', it publishes a 'ftustarted' event. Accessibility is listening for
> this event and confuses it with the event it is actually waiting for, which
> is a relayed IAC 'started' event from the FTU. So its just an event name
> overloading issue. I have a patch in th eworks.

Thanks this also fixes an issue where even if the FTU is present, and stepped through, the screen reader is heard.

Comment 8

[GitHub Autolander Bot]

Attachment: [gaia] sfoster:accessibility-setup-bug-1215216 > mozilla-b2g:master

Comment 9

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8674973 [details] [review]
[gaia] sfoster:accessibility-setup-bug-1215216 > mozilla-b2g:master

Kevin, I think this is driving everyone a bit crazy so I was looking for a reviewer in an ASAP-friendly timezone. But please forward along if you prefer.

Comment 10

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8674973 [details] [review]
[gaia] sfoster:accessibility-setup-bug-1215216 > mozilla-b2g:master

In this patch I also added a window.removeEventListener('ftu-comms') where you remove the 'ftustep' listener. Does that look ok?

Comment 11

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8674973 [details] [review]
[gaia] sfoster:accessibility-setup-bug-1215216 > mozilla-b2g:master

Hi Sam, it seems like you handled started event but a11y also relies on the step event that doesn't seem to be updated.

Comment 12

[Sam Foster [:sfoster] (he/him)]

> Hi Sam, it seems like you handled started event but a11y also relies on the
> step event that doesn't seem to be updated.

I didn't make any change to the ftustep event (re-published by FtuLauncher) but you're right it would be more consistent to handle both the same way. Will update the patch.

Comment 13

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8674973 [details] [review]
[gaia] sfoster:accessibility-setup-bug-1215216 > mozilla-b2g:master

Yura I've updated the PR to use the ftucomms events for both 'started' and 'step'. I've run through this a few different ways, but can you check the logic and end result remain the same?

Comment 14

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8674973 [details] [review]
[gaia] sfoster:accessibility-setup-bug-1215216 > mozilla-b2g:master

Works well now thanks!

Comment 15

[Kevin Grandon :kgrandon]

Comment on attachment 8674973 [details] [review]
[gaia] sfoster:accessibility-setup-bug-1215216 > mozilla-b2g:master

Better, but I think we should kill this for the first boot /w FTU as well ;-)

Comment 16

[Kevin Grandon :kgrandon]

Gaia-try links are busted, but I saw this pas on the gaia treeherder list. Should be good to land. Thanks!

In master: https://github.com/mozilla-b2g/gaia/commit/bff003a5c8968b62dad4d60f76b9fe39ecc63eb3