Don't flush restored tabs (delete then insert) before and after loading about/home, delaying issuing top sites query

RESOLVED FIXED

Status

()

Firefox for iOS
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: rnewman, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

2 years ago
2015-10-15 12:54:40.264 [Debug] [SwiftData.swift:388] executeChange(_:withArgs:) > -------
SQL CHANGE: 
BEGIN EXCLUSIVE
-------
2015-10-15 12:54:40.265 [Debug] [SwiftData.swift:388] executeChange(_:withArgs:) > -------
SQL CHANGE: 
DELETE FROM tabs WHERE client_guid IS ?
-------
2015-10-15 12:54:40.265 [Debug] [SwiftData.swift:388] executeChange(_:withArgs:) > -------
SQL CHANGE: 
COMMIT
-------
2015-10-15 12:54:40.336 [Debug] [SwiftData.swift:416] executeQuery(_:factory:withArgs:) > -------
SQL QUERY: 
SELECT historyID, url, title, guid, domain_id, domain, localVisitDate, remoteVisitDate, localVisitCount,
(Reporter)

Comment 1

2 years ago
Then we do it *again* immediately after loading about/home!

[DEBUG] Connection sent 113 bytes on socket 16
[DEBUG] Did close connection on socket 16
[VERBOSE] [::1:6571] ::1:51735 405 "GET /about/home/" (378 | 113)
2015-10-15 12:54:40.387 Client[63393:14884466] <UIVisualEffectView 0x7fc4f355abe0> is being asked to animate its opacity. This will cause the effect to appear broken until opacity returns to 1.
2015-10-15 12:54:40.690 [Debug] [SwiftData.swift:388] executeChange(_:withArgs:) > -------
SQL CHANGE: 
BEGIN EXCLUSIVE
-------
2015-10-15 12:54:40.691 [Debug] [SwiftData.swift:388] executeChange(_:withArgs:) > -------
SQL CHANGE: 
DELETE FROM tabs WHERE client_guid IS ?
-------
2015-10-15 12:54:40.691 [Debug] [SwiftData.swift:388] executeChange(_:withArgs:) > -------
SQL CHANGE: 
COMMIT
-------
Summary: Don't flush restored tabs (delete then insert) before issuing top sites query → Don't flush restored tabs (delete then insert) before and after loading about/home, delaying issuing top sites query
(Reporter)

Comment 2

2 years ago
Same PR as the other two bugs I just filed.
(Reporter)

Comment 3

2 years ago
bee6d41
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.