1215293 - Music close icon next to search box would not close or function.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[[:VladimirBelonenko]]

Attachment: logcat_20151015_1336.txt

Description:
When user opens a music app and tries to click on close icon. The icon does not close.

Repro Steps:
1) Update a Aries to 20151015110122
2) Select music app
3) Observe that close icon next to search box does not function.

Actual:
Open music app and select close icon top right corner. Icon is frozen does not function.

Expected:
Close icon next to search box should give user a different output when it closes.

Environmental Variables:
Device: Aries Master 2.5 kk full flash 
Build ID: 20151015110122
Gaia: 40ae7c292a36156458c66712b4bd61ecbe69272a
Gecko: e193b4da0a8c1025aa76a403c64663ff1cd41709
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 44.0a1 (Master)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Repro frequency: 3/3
See attached: video clip and logcat

Comment 1

[[:VladimirBelonenko]]

This result does occur on 2.5 flame
Result: Open music app and select close icon top right corner. Icon is frozen does not function.

Environmental Variables:
Device: Flame Master 2.5 kk full flash
Build ID: 20151015030226
Gaia: 40ae7c292a36156458c66712b4bd61ecbe69272a
Gecko: e193b4da0a8c1025aa76a403c64663ff1cd41709
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 44.0a1 (Master)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Notes: This issue is a regression NGA, it's happening on older and newer flame 2.2

Comment 2

[Justin D'Arcangelo [:justindarc]]

This is a CSS issue that only happens if you don't have enough songs on the tiles view for it to be scrollable. I'll take this to fix.

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] justindarc:bug1215293 > mozilla-b2g:master

Comment 4

[Jim Porter (:squib)]

Comment on attachment 8674569 [details] [review]
[gaia] justindarc:bug1215293 > mozilla-b2g:master

Seems sane to me. One minor comment on GitHub.

Comment 5

[Justin D'Arcangelo [:justindarc]]

Landed on master:

https://github.com/mozilla-b2g/gaia/commit/badac959a9ce25f7c168b09842341f4d7a7b5ba8

Comment 6

[Sxean Lee-David [:sxean]]

NO REPRO per build: 

Environmental Variables:
Device: Aries 2.5
BuildID: 20151019104907
Gaia: f75bd584aca0a751a5bed115800250faa8412927
Gecko: d3e87bb40753327550143ba8ac8ee27b300cd4a9
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 44.0a1 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

RESULT: 
When tap on the search music [close] button, at the upper-right of the 
Music App when viewing a "list" of music, the [close] bar closes the music app Search bar.