Maintain coded group continuity in sequence append mode

RESOLVED FIXED in Firefox 44

Status

()

P2
normal
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: jya, Assigned: jya)

Tracking

(Blocks: 1 bug)

unspecified
mozilla44
Points:
---

Firefox Tracking Flags

(firefox44 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
This change was made to the MSE spec on September 17th, 2015:
"Bug 29133 - Maintain coded group continuity in sequence append mode when resetting parser state."
(Assignee)

Updated

4 years ago
Blocks: 778617
Priority: -- → P2
(Assignee)

Updated

4 years ago
Assignee: nobody → jyavenard
Comment on attachment 8678688 [details] [diff] [review]
Maintain coded group continuity in sequence append mode when resetting parser state.

Review of attachment 8678688 [details] [diff] [review]:
-----------------------------------------------------------------

r+ after complete renumbering.

::: dom/media/mediasource/TrackBuffersManager.cpp
@@ +381,5 @@
> +  if (mSourceBufferAttributes->GetAppendMode() == SourceBufferAppendMode::Sequence) {
> +    mGroupStartTimestamp = Some(mGroupEndTimestamp);
> +  }
> +
> +  // 7. Remove all bytes from the input buffer.

I believe there's another item below that you'll need to renumber from 7 to 8.
Attachment #8678688 - Flags: review?(gsquelart) → review+

Comment 4

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5304f2ce54aa
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Depends on: 1209434
(Assignee)

Updated

3 years ago
No longer depends on: 1209434
You need to log in before you can comment on or make changes to this bug.