1215370 - Maintain coded group continuity in sequence append mode

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[Jean-Yves Avenard [:jya]]

This change was made to the MSE spec on September 17th, 2015:
"Bug 29133 - Maintain coded group continuity in sequence append mode when resetting parser state."

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Maintain coded group continuity in sequence append mode when resetting parser state.

W3C issue 29133.

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8678688 [details] [diff] [review]
Maintain coded group continuity in sequence append mode when resetting parser state.

Review of attachment 8678688 [details] [diff] [review]:
-----------------------------------------------------------------

r+ after complete renumbering.

::: dom/media/mediasource/TrackBuffersManager.cpp
@@ +381,5 @@
> +  if (mSourceBufferAttributes->GetAppendMode() == SourceBufferAppendMode::Sequence) {
> +    mGroupStartTimestamp = Some(mGroupEndTimestamp);
> +  }
> +
> +  // 7. Remove all bytes from the input buffer.

I believe there's another item below that you'll need to renumber from 7 to 8.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5304f2ce54aa

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5304f2ce54aa