Closed Bug 1215370 Opened 5 years ago Closed 5 years ago

Maintain coded group continuity in sequence append mode

Categories

(Core :: Audio/Video: Playback, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: jya, Assigned: jya)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

This change was made to the MSE spec on September 17th, 2015:
"Bug 29133 - Maintain coded group continuity in sequence append mode when resetting parser state."
Blocks: MSE
Priority: -- → P2
Assignee: nobody → jyavenard
Comment on attachment 8678688 [details] [diff] [review]
Maintain coded group continuity in sequence append mode when resetting parser state.

Review of attachment 8678688 [details] [diff] [review]:
-----------------------------------------------------------------

r+ after complete renumbering.

::: dom/media/mediasource/TrackBuffersManager.cpp
@@ +381,5 @@
> +  if (mSourceBufferAttributes->GetAppendMode() == SourceBufferAppendMode::Sequence) {
> +    mGroupStartTimestamp = Some(mGroupEndTimestamp);
> +  }
> +
> +  // 7. Remove all bytes from the input buffer.

I believe there's another item below that you'll need to renumber from 7 to 8.
Attachment #8678688 - Flags: review?(gsquelart) → review+
https://hg.mozilla.org/mozilla-central/rev/5304f2ce54aa
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Depends on: 1209434
No longer depends on: 1209434
You need to log in before you can comment on or make changes to this bug.