Closed
Bug 1215396
Opened 9 years ago
Closed 9 years ago
Log Safe Browsing prefixes as they are added to the local database
Categories
(Toolkit :: Safe Browsing, defect)
Toolkit
Safe Browsing
Tracking
()
RESOLVED
FIXED
mozilla44
| Tracking | Status | |
|---|---|---|
| firefox44 | --- | fixed |
People
(Reporter: francois, Assigned: francois)
References
Details
Attachments
(1 file)
|
5.44 KB,
patch
|
gcp
:
review+
|
Details | Diff | Splinter Review |
This will allow us to see when particular prefixes get added / removed by the Safe Browsing server.
NSPR_LOG_MODULES=UrlClassifierProtocolParser:5
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8674662 -
Flags: review?(gpascutto)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8674662 [details] [diff] [review]
bug1215396.patch
Review of attachment 8674662 [details] [diff] [review]:
-----------------------------------------------------------------
Seems very spammy to me. Maybe want to consider making different log levels?
Attachment #8674662 -
Flags: review?(gpascutto) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
(In reply to Gian-Carlo Pascutto [:gcp] from comment #2)
> Seems very spammy to me. Maybe want to consider making different log levels?
Yeah, it is pretty spammy, but there aren't that many log levels:
https://dxr.mozilla.org/mozilla-central/rev/d374d16cbb251c9dac5af69f8e186e821ce82fe2/nsprpub/pr/include/prlog.h#107-111
None of the PARSER_LOG() lines really feel like warnings to me.
The good thing is that it's pretty rare (I think) that we need to enable that particular LOG_MODULE.
|
||
Comment 5•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
|
|
||
Comment 6•9 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•