Closed
Bug 1215424
Opened 9 years ago
Closed 9 years ago
use CSSParseResult return value in ParseBoxPropertyVariant in place of its |bool& aConsumedTokens| argument
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla44
| Tracking | Status | |
|---|---|---|
| firefox44 | --- | fixed |
People
(Reporter: heycam, Assigned: dbaron)
Details
Attachments
(1 file)
|
6.98 KB,
patch
|
heycam
:
review+
|
Details | Diff | Splinter Review |
We can follow the approach in bug 1213076 and make ParseBoxPropertyVariant return a CSSParseResult rather than return a boolean and set an aConsumedTokens outparam.
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → dbaron
|
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8675947 -
Flags: review?(cam)
|
Reporter | |
Comment 2•9 years ago
|
||
Comment on attachment 8675947 [details] [diff] [review]
Convert ParseBoxProperty and ParseBoxPropertyVariant to CSSParseResult
Review of attachment 8675947 [details] [diff] [review]:
-----------------------------------------------------------------
Since the only point of ParseBoxPropertyVariant was to have the aConsumedTokens outparam, I think we should just remove it and replace calls to it with calls to ParseVariantWithRestrictions. r=me with that.
Attachment #8675947 -
Flags: review?(cam) → review+
|
||
Comment 4•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
|
|
||
Comment 5•9 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•