use CSSParseResult return value in ParseBoxPropertyVariant in place of its |bool& aConsumedTokens| argument

RESOLVED FIXED in Firefox 44

Status

()

Core
CSS Parsing and Computation
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: heycam, Assigned: dbaron)

Tracking

Trunk
mozilla44
Points:
---

Firefox Tracking Flags

(firefox44 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
We can follow the approach in bug 1213076 and make ParseBoxPropertyVariant return a CSSParseResult rather than return a boolean and set an aConsumedTokens outparam.
(Assignee)

Updated

2 years ago
Assignee: nobody → dbaron
(Assignee)

Comment 1

2 years ago
Created attachment 8675947 [details] [diff] [review]
Convert ParseBoxProperty and ParseBoxPropertyVariant to CSSParseResult
Attachment #8675947 - Flags: review?(cam)
(Reporter)

Comment 2

2 years ago
Comment on attachment 8675947 [details] [diff] [review]
Convert ParseBoxProperty and ParseBoxPropertyVariant to CSSParseResult

Review of attachment 8675947 [details] [diff] [review]:
-----------------------------------------------------------------

Since the only point of ParseBoxPropertyVariant was to have the aConsumedTokens outparam, I think we should just remove it and replace calls to it with calls to ParseVariantWithRestrictions. r=me with that.
Attachment #8675947 - Flags: review?(cam) → review+

Comment 3

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/48fff3ec4d81
https://hg.mozilla.org/mozilla-central/rev/48fff3ec4d81
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox44: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
https://hg.mozilla.org/mozilla-central/rev/48fff3ec4d81
You need to log in before you can comment on or make changes to this bug.