1215429 - [Simulator] Can't access to File object in chrome code of TVSimulatorService.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Simulator, defect)

Description

[Mantaroh Yoshinaga[:mantaroh]]

Attachment: WIP:Adding import statement in order to access file object at chrome code.

I added the code of loading video file at bug 1180589.

However I forgot importing the File Object to global scope.
So current code can't access to video file.

Comment 1

[Mantaroh Yoshinaga[:mantaroh]]

Attachment: Adding import statement in order to access file object at chrome code.

Hi Sean,

I forgot adding to import statement of File.
So current code can't access to the video file.

The root cause of bug 1214520 is this issue.

Comment 2

[James Cheng[:JamesCheng]]

Hi Mantaroh,

I also want to fix this issue by |new aWin.File(....)|.

But I will get a failure return value(NS_ERROR_FAILURE 0x80004005) at

https://dxr.mozilla.org/mozilla-central/rev/d374d16cbb251c9dac5af69f8e186e821ce82fe2/dom/tv/TVTuner.cpp#283

Do you know why I cannot use aWin to access class File?

Using the approach of your patch can work fine....

Thanks.

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Can we get a try run for this patch?

Comment 4

[Mantaroh Yoshinaga[:mantaroh]]

Hi James,

Thank you for confirm.

(In reply to James Cheng[:JamesCheng] from comment #2)
> Hi Mantaroh,
> 
> I also want to fix this issue by |new aWin.File(....)|.
> 
> But I will get a failure return value(NS_ERROR_FAILURE 0x80004005) at
> 
> https://dxr.mozilla.org/mozilla-central/rev/
> d374d16cbb251c9dac5af69f8e186e821ce82fe2/dom/tv/TVTuner.cpp#283
> 
> Do you know why I cannot use aWin to access class File?
The aWin parameter is content's window, and content can't access the local file. So we can't create File object using aWin parameter. We should access to local file at chrome code using importGlobalProperties[1].

[1] https://developer.mozilla.org/ja/docs/Extensions/Using_the_DOM_File_API_in_chrome_code

best regards.

Comment 5

[Mantaroh Yoshinaga[:mantaroh]]

Hi Wes,

(In reply to Wes Kocher (:KWierso) from comment #3)
> Can we get a try run for this patch?
Of course!
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e8ecaf7bd794

However I skipped some test and builds.
So I tried full build and tests again.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bf626168d04c

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/8d2a024c6892

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8d2a024c6892