1215435 - Assertion failure: ACodec permits valid buffer + EOS flag.

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[John Lin [:jhlin][:jolin]]

Attachment: Assert output buffer with EOS flag.

Assertion failure found in bug 1207214 comment 10. The original assertion incorrectly assumes that decoder always emits an empty buffer with EOS flag after final output buffer. Turns out ACodec permits sending EOS flag along with final output buffer.

Comment 1

[John Lin [:jhlin][:jolin]]

Carry Sotaro's r+ from bug 1207214 comment 19.

Comment 2

[John Lin [:jhlin][:jolin]]

Attachment: Assert output buffer with EOS flag.

Fix commit message.

Comment 3

[John Lin [:jhlin][:jolin]]

Try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=19bf86a7246d

Comment 4

[Carsten Book [:Tomcat]]

Hi, this failed to apply:

pplying bug1207214-assert-EOS-with-buffer.patch
patching file dom/media/platforms/gonk/GonkMediaDataDecoder.cpp
Hunk #1 FAILED at 196
1 out of 1 hunks FAILED -- saving rejects to file dom/media/platforms/gonk/GonkMediaDataDecoder.cpp.rej

could you take a look, thanks!

Comment 5

[John Lin [:jhlin][:jolin]]

Already checked in bug 1207214 comment 21. Sorry for the mess.