We shouldn't ship RTCCertificate.expires as a Date

RESOLVED FIXED in Firefox 42

Status

()

defect
P1
normal
Rank:
15
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: bzbarsky, Assigned: mt)

Tracking

Trunk
mozilla44
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox42 fixed, firefox43 fixed, firefox44 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

[Tracking Requested - why for this release]: Last chance to avoid shipping an API we don't want to ship.

See https://github.com/w3c/webrtc-pc/issues/324 and https://www.w3.org/Bugs/Public/show_bug.cgi?id=22824 for details.  We haven't shipped this on the web yet, so this is our chance to not make that mistake....  Given this is in 42, it's our last chance, though, right?

We should just return a long long instead, I think.
Flags: needinfo?(martin.thomson)
Assignee

Comment 1

4 years ago
Spec change requested: https://github.com/w3c/webrtc-pc/pull/342
Assignee

Comment 2

4 years ago
WDYT?
Flags: needinfo?(martin.thomson)
Attachment #8675188 - Flags: review?(bzbarsky)
Comment on attachment 8675188 [details] [diff] [review]
0001-Bug-1215519-Switch-to-DOMTimeStamp-for-RTCCertificat.patch

r=me
Attachment #8675188 - Flags: review?(bzbarsky) → review+
backlog: --- → webrtc/webaudio+
Rank: 15
Priority: -- → P1
Tracking as it is the last moment (beta 9 gtb is tomorrow) to get that.
Bz, Martin, could you fill the uplift request? Thanks
Assignee: nobody → martin.thomson
Flags: needinfo?(martin.thomson)
Flags: needinfo?(bzbarsky)
Keywords: checkin-needed
Assignee

Comment 5

4 years ago
Approval Request Comment
[Feature/regressing bug #]: 1215519
[User impact if declined]: none, but releasing a feature we don't want makes it very hard to remove later
[Describe test coverage new/current, TreeHerder]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=76d7051252ac
[Risks and why]: there are some users who might be relying on this being a Date; I can probably personally talk to them though
[String/UUID change made/needed]: none
Attachment #8675188 - Attachment is obsolete: true
Flags: needinfo?(martin.thomson)
Flags: needinfo?(bzbarsky)
Attachment #8676971 - Flags: review+
Attachment #8676971 - Flags: approval-mozilla-beta?
Attachment #8676971 - Flags: approval-mozilla-aurora?
Comment on attachment 8676971 [details] [diff] [review]
bug1215519v2.patch

Now is the time (or never), should be in 42 beta 9.
Attachment #8676971 - Flags: approval-mozilla-beta?
Attachment #8676971 - Flags: approval-mozilla-beta+
Attachment #8676971 - Flags: approval-mozilla-aurora?
Attachment #8676971 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/7dc8fdb76c6a
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
https://hg.mozilla.org/releases/mozilla-aurora/rev/4018d92c9f2a

but it has problems to apply to beta:

merging dom/media/PeerConnection.js
merging dom/media/webrtc/RTCCertificate.h
warning: conflicts during merge.
merging dom/media/webrtc/RTCCertificate.h incomplete! (edit conflicts, then use 'hg resolve --mark')

could you take a look ?
Flags: needinfo?(martin.thomson)
Assignee

Comment 10

4 years ago
https://hg.mozilla.org/releases/mozilla-beta/rev/e91b6fcbc1bb

Only trivial changes required.
Flags: needinfo?(martin.thomson)
You need to log in before you can comment on or make changes to this bug.