1215519 - We shouldn't ship RTCCertificate.expires as a Date

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect, P1)

Description

[Boris Zbarsky [:bzbarsky]]

[Tracking Requested - why for this release]: Last chance to avoid shipping an API we don't want to ship.

See https://github.com/w3c/webrtc-pc/issues/324 and https://www.w3.org/Bugs/Public/show_bug.cgi?id=22824 for details.  We haven't shipped this on the web yet, so this is our chance to not make that mistake....  Given this is in 42, it's our last chance, though, right?

We should just return a long long instead, I think.

Comment 1

[Martin Thomson [:mt:]]

Spec change requested: https://github.com/w3c/webrtc-pc/pull/342

Comment 2

[Martin Thomson [:mt:]]

Attachment: 0001-Bug-1215519-Switch-to-DOMTimeStamp-for-RTCCertificat.patch

WDYT?

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8675188 [details] [diff] [review]
0001-Bug-1215519-Switch-to-DOMTimeStamp-for-RTCCertificat.patch

r=me

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Tracking as it is the last moment (beta 9 gtb is tomorrow) to get that.
Bz, Martin, could you fill the uplift request? Thanks

Comment 5

[Martin Thomson [:mt:]]

Attachment: bug1215519v2.patch

Approval Request Comment
[Feature/regressing bug #]: 1215519
[User impact if declined]: none, but releasing a feature we don't want makes it very hard to remove later
[Describe test coverage new/current, TreeHerder]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=76d7051252ac
[Risks and why]: there are some users who might be relying on this being a Date; I can probably personally talk to them though
[String/UUID change made/needed]: none

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7dc8fdb76c6a

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8676971 [details] [diff] [review]
bug1215519v2.patch

Now is the time (or never), should be in 42 beta 9.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7dc8fdb76c6a

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4018d92c9f2a

but it has problems to apply to beta:

merging dom/media/PeerConnection.js
merging dom/media/webrtc/RTCCertificate.h
warning: conflicts during merge.
merging dom/media/webrtc/RTCCertificate.h incomplete! (edit conflicts, then use 'hg resolve --mark')

could you take a look ?

Comment 10

[Martin Thomson [:mt:]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e91b6fcbc1bb

Only trivial changes required.