Closed Bug 1215567 Opened 4 years ago Closed 4 years ago

Increase toolbarHighlight opacity to 40%

Categories

(Firefox :: Theme, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 44
Tracking Status
firefox44 --- fixed

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file)

Spinning this off from bug 1214707.
Attachment #8674938 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8674938 [details] [diff] [review]
toolbarHighlight.diff

Review of attachment 8674938 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with a fix to make this actually update the tab images as noted in the comments in the other bug.
Attachment #8674938 - Flags: review?(gijskruitbosch+bugs) → review+
(In reply to :Gijs Kruitbosch from comment #1)
> Comment on attachment 8674938 [details] [diff] [review]
> toolbarHighlight.diff
> 
> Review of attachment 8674938 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=me with a fix to make this actually update the tab images as noted in the
> comments in the other bug.

A clobber / fresh build (this includes nightly builds) would do that. Incremental builds temporarily not getting this update (or only part of it, since presumably the updated toolbarHighlight would be used in browser.css) doesn't worry me too much right now. I don't exactly understand what's going on there, so I'm weary of adding workarounds.
I'm also not a fan of the proposed workaround because tab-selected.svg's license header is actually as it should be whereas the *.inc files really should have preprocessed license headers.
https://hg.mozilla.org/mozilla-central/rev/3806c31de1f4
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Depends on: 1244500
You need to log in before you can comment on or make changes to this bug.