1215567 - Increase toolbarHighlight opacity to 40%

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Dão Gottwald [:dao]]

Attachment: toolbarHighlight.diff

Spinning this off from bug 1214707.

Comment 1

[:Gijs (he/him)]

Comment on attachment 8674938 [details] [diff] [review]
toolbarHighlight.diff

Review of attachment 8674938 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with a fix to make this actually update the tab images as noted in the comments in the other bug.

Comment 2

[Dão Gottwald [:dao]]

(In reply to :Gijs Kruitbosch from comment #1)
> Comment on attachment 8674938 [details] [diff] [review]
> toolbarHighlight.diff
> 
> Review of attachment 8674938 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=me with a fix to make this actually update the tab images as noted in the
> comments in the other bug.

A clobber / fresh build (this includes nightly builds) would do that. Incremental builds temporarily not getting this update (or only part of it, since presumably the updated toolbarHighlight would be used in browser.css) doesn't worry me too much right now. I don't exactly understand what's going on there, so I'm weary of adding workarounds.

Comment 3

[Dão Gottwald [:dao]]

I'm also not a fan of the proposed workaround because tab-selected.svg's license header is actually as it should be whereas the *.inc files really should have preprocessed license headers.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/3806c31de1f4

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3806c31de1f4