Closed
Bug 1215573
Opened 9 years ago
Closed 9 years ago
Remove AutoWritableJitCode from IonCache::updateBaseAddress
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla44
| Tracking | Status | |
|---|---|---|
| firefox44 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(1 file)
|
2.47 KB,
patch
|
nbp
:
review+
|
Details | Diff | Splinter Review |
Just noticed there's an AutoWritableJitCode in updateBaseAddress, this is called for each cache when creating an IonScript. We can avoid reprotecting JIT code if we just move the copyCacheEntries call inside the scope of the AutoWritableJitCode in CodeGenerator::link.
Attachment #8674946 -
Flags: review?(nicolas.b.pierron)
|
||
Comment 1•9 years ago
|
||
Comment on attachment 8674946 [details] [diff] [review] Patch Review of attachment 8674946 [details] [diff] [review]: ----------------------------------------------------------------- Good catch!
Attachment #8674946 -
Flags: review?(nicolas.b.pierron) → review+
|
||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/75c673cd65ea
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•