Closed Bug 1215573 Opened 8 years ago Closed 8 years ago

Remove AutoWritableJitCode from IonCache::updateBaseAddress

Categories

(Core :: JavaScript Engine: JIT, defect)

Product:
Core
Component:
JavaScript Engine: JIT
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla44
Tracking Flags:
Tracking Status
firefox44 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(1 file)

Patch
2.47 KB, patch
nbp
: review+
Details | Diff | Splinter Review
Attached patch Patch — — Splinter Review 
Just noticed there's an AutoWritableJitCode in updateBaseAddress, this is called for each cache when creating an IonScript.

We can avoid reprotecting JIT code if we just move the copyCacheEntries call inside the scope of the AutoWritableJitCode in CodeGenerator::link.
Attachment #8674946 - Flags: review?(nicolas.b.pierron)
Comment on attachment 8674946 [details] [diff] [review]
Patch

Review of attachment 8674946 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch!
Attachment #8674946 - Flags: review?(nicolas.b.pierron) → review+
https://hg.mozilla.org/mozilla-central/rev/75c673cd65ea
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.