Remove AutoWritableJitCode from IonCache::updateBaseAddress

RESOLVED FIXED in Firefox 44

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

unspecified
mozilla44
Points:
---

Firefox Tracking Flags

(firefox44 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8674946 [details] [diff] [review]
Patch

Just noticed there's an AutoWritableJitCode in updateBaseAddress, this is called for each cache when creating an IonScript.

We can avoid reprotecting JIT code if we just move the copyCacheEntries call inside the scope of the AutoWritableJitCode in CodeGenerator::link.
Attachment #8674946 - Flags: review?(nicolas.b.pierron)
Comment on attachment 8674946 [details] [diff] [review]
Patch

Review of attachment 8674946 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch!
Attachment #8674946 - Flags: review?(nicolas.b.pierron) → review+
https://hg.mozilla.org/mozilla-central/rev/75c673cd65ea
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.