Closed Bug 1215573 Opened 4 years ago Closed 4 years ago

Remove AutoWritableJitCode from IonCache::updateBaseAddress

Categories

(Core :: JavaScript Engine: JIT, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
Just noticed there's an AutoWritableJitCode in updateBaseAddress, this is called for each cache when creating an IonScript.

We can avoid reprotecting JIT code if we just move the copyCacheEntries call inside the scope of the AutoWritableJitCode in CodeGenerator::link.
Attachment #8674946 - Flags: review?(nicolas.b.pierron)
Comment on attachment 8674946 [details] [diff] [review]
Patch

Review of attachment 8674946 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch!
Attachment #8674946 - Flags: review?(nicolas.b.pierron) → review+
https://hg.mozilla.org/mozilla-central/rev/75c673cd65ea
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.