1215582 - Rename Blacklist to Blocklist in GstreamerFormatHelper

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[Ralph Giles (:rillian)]

The term 'Blacklist' always bothered me. Use the less colour-related 'Blocklist' term instead.

Comment 1

[Ralph Giles (:rillian)]

Attachment: Rename patch

Comment 2

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Blacklist has the virtue of being an actual word. http://www.oxforddictionaries.com/spellcheck/english/?q=blocklist

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8674980 [details] [diff] [review]
Rename patch

Review of attachment 8674980 [details] [diff] [review]:
-----------------------------------------------------------------

r+, but you should also wchange the remaining "blacklist"'s in some comments:
GStreamerReader.cpp:1209: * blacklist.
GStreamerReader.cpp:1246: * candidate factories to continue decoding the stream. We apply the blacklist
GStreamerReader.h:96:   * constructed, we can then list for its autoplug-sort signal to blacklist
GStreamerReader.h:197:   * container/codec blacklist.

And to address Anthony's comment:
(In reply to Anthony Jones (:kentuckyfriedtakahe, :k17e) from comment #2)
> Blacklist has the virtue of being an actual word.
> http://www.oxforddictionaries.com/spellcheck/english/?q=blocklist
You could capitalize the 'L' or separate words, e.g.: sBlockListEnabled, block list.

::: dom/media/gstreamer/GStreamerFormatHelper.cpp
@@ +227,1 @@
>                                   "media.gstreamer.enable-blacklist", true);

How about changing the pref as well?

Comment 4

[Ralph Giles (:rillian)]

Attachment: Rename patch v2

Updated patch addressing comments. Carrying forward r=gerald.

s/Blocklist/BlockList/ and s/blocklist/block list/. I left the pref as before to avoid breaking customizations, after discussion with Chris Peterson.

Comment 5

[Ralph Giles (:rillian)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=186f7e4035fc

Comment 6

[Ralph Giles (:rillian)]

Attachment: Rename patch v3

Fix encoding problem with the first line of the patch. Thanks to gerald for the extra review.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e129ed7e555e

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e129ed7e555e