1215599 - Imagecompare: fix test_settings_NC_RTL.py where change_passcode is not tapped

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[No-Jun Park [:njpark]]

Apparently, when the element is only partially visible, it doesn't scroll the element to view, but it is not sufficient to have it 'visible' so it can be tapped.

10:00:55  1:33.55 TEST_START: MainThread test_settings_NC_RTL.py TestSettingsRTLNC.test_settings_app
10:04:48  5:26.04 TEST_END: MainThread ERROR, expected PASS
10:04:48 Traceback (most recent call last):
10:04:48   File "/var/jenkins/1/workspace/flame-kk-512.mozilla-central.nightly.ui.graphics.reference.RTL/.env/local/lib/python2.7/site-packages/marionette_client-1.0.0-py2.7.egg/marionette/marionette_test.py", line 296, in run
10:04:48     testMethod()
10:04:48   File "/var/jenkins/1/workspace/flame-kk-512.mozilla-central.nightly.ui.graphics.reference.RTL/tests/python/gaia-ui-tests/gaiatest/tests/graphics/RTL/test_settings_NC_RTL.py", line 114, in test_settings_app
10:04:48     cs_page.tap_change_passcode()
10:04:48   File "/var/jenkins/1/workspace/flame-kk-512.mozilla-central.nightly.ui.graphics.reference.RTL/tests/python/gaia-ui-tests/gaiatest/apps/settings/regions/call_settings.py", line 266, in tap_change_passcode
10:04:48     Wait(self.marionette).until(expected.element_displayed(*self._passcode_page_locator))
10:04:48   File "/var/jenkins/1/workspace/flame-kk-512.mozilla-central.nightly.ui.graphics.reference.RTL/.env/local/lib/python2.7/site-packages/marionette_driver-1.0.0-py2.7.egg/marionette_driver/wait.py", line 143, in until
10:04:48     cause=last_exc)
10:04:48 TimeoutException: TimeoutException: Timed out after 10.0 seconds
10:04:48

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] npark-mozilla:1215599 > mozilla-b2g:master

Comment 2

[No-Jun Park [:njpark]]

I thought we fixed this, but maybe I remembered it wrong.

Comment 3

[Martijn Wargers (dead)]

Comment on attachment 8675026 [details] [review]
[gaia] npark-mozilla:1215599 > mozilla-b2g:master

Looks good to me.
This seems a case where tap() doesn't work, even though it's supposed to scrollintoview the element when the tap area is outside of the viewport.

Comment 4

[No-Jun Park [:njpark]]

Merged:

https://github.com/mozilla-b2g/gaia/commit/b66adfef23d78e021e3ac0b5d8631bf9b42da510