1215616 - wrong raddr and rport in srflx ice candidates

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect, P1)

Description

[Ben Schwartz]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/47.0.2526.8 Safari/537.36

Steps to reproduce:

Started a peerconnection with a STUN server


Actual results:

Got this candidate out:
candidate:8 1 UDP 1694179327 216.239.33.166 56450 typ srflx raddr 216.239.33.166 rport 56450


Expected results:

The raddr should have been the address of one of the actual local interfaces

This appears to be a regression between Firefox 41 and Firefox 42.  The problem may have been introduced as a side effect of IP privacy changes.  The problem is very similar to #931700, but that bug only affected relay candidates, and was already present in Firefox 41

Comment 1

[Nils Ohlmeier [:drno]]

Easily reproducible by opening http://mozilla.github.io/webrtc-landing/stun_test.html with Fx 41 and 42.

Comment 2

[Nils Ohlmeier [:drno]]

Attachment: MozReview Request: Bug 1215616: use base address for server rflx candidates. r?bwc

Bug 1215616: use base address for server rflx candidates. r?bwc

Comment 3

[Byron Campen [:bwc]]

Comment on attachment 8675230 [details]
MozReview Request: Bug 1215616: use base address for server rflx candidates. r?bwc

https://reviewboard.mozilla.org/r/22353/#review19957

Ha! Awesome.

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

Ouch... and we need to get this in ASAP and nominate it for uplifts.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/17dae8ef3e63

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

I preemptively landed this so it could bake (and get into m-c this weekend, maybe).

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/17dae8ef3e63

Comment 8

[Nils Ohlmeier [:drno]]

Comment on attachment 8675230 [details]
MozReview Request: Bug 1215616: use base address for server rflx candidates. r?bwc

Just requesting early, so we have the approvals in time.

Approval Request Comment
[Feature/regressing bug #]: The bug got introduce via bug 1189041, which landed in 43 and got uplifted to 42.
[User impact if declined]: The ICE candidates handed out by the WebRTC APIs are presenting wrong IP addresses. It should not affect the ability to establish WebRTC connection, but there might be WebRTC implementations which cause trouble with these wrong ICE candidates.
[Describe test coverage new/current, TreeHerder]: Manually tested.
[Risks and why]: The risk is extremly low as it is only a one line change which restores the behavior from before bug 1189041 landed.
[String/UUID change made/needed]: n/a

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8675230 [details]
MozReview Request: Bug 1215616: use base address for server rflx candidates. r?bwc

Should be in 42 beta 8.

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/563f8cbe3bf6

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c3daaf421fe6