Closed Bug 1215659 Opened 4 years ago Closed 4 years ago

newtab tile's page thumbnail is not scaled correctly (HiDPI problem?)

Categories

(Firefox :: New Tab Page, defect)

All
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 45
Tracking Status
e10s + ---
firefox44 --- fixed
firefox45 --- fixed
b2g-v2.5 --- fixed

People

(Reporter: cpeterson, Assigned: mchang)

References

Details

Attachments

(2 files)

Attached image newtab-screenshot.png
I am using Nightly 44 with e10s on a Retina MacBook Pro. I have seen similar content scaling bugs when dragging e10s browser windows between my MacBook Pro's builtin Retina display and an external non-HiDPI display, e.g. bug 1125325 and bug 978913.

See the attached screenshot.
Might be a regression from bug 1197361.
Flags: needinfo?(mchang)
Yup, probably a regression from 1197361.
Assignee: nobody → mchang
Flags: needinfo?(mchang)
See Also: → 1214428
There was a problem, where sometimes we would be provided with a destination canvas already, but we'd go down a path to try to take the snapshot at a size smaller than the destination canvas. In those cases, just try to snapshot at the destination canvas size.

Also, sometimes, we'd get a black canvas because nsIProgressWatcher would actually give us an error, but we'd continue to snapshot the page. The web content wasn't actually ready, so we'd snapshot nothing.
Attachment #8677208 - Flags: review?(ttaubert)
Attachment #8677208 - Flags: review?(ttaubert) → review?(adw)
Comment on attachment 8677208 [details] [diff] [review]
Use destination canvas as thumbnail size

Review of attachment 8677208 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for fixing that second problem too, that's great.
Attachment #8677208 - Flags: review?(adw) → review+
https://hg.mozilla.org/mozilla-central/rev/f6b31718d94d
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
Comment on attachment 8677208 [details] [diff] [review]
Use destination canvas as thumbnail size

Approval Request Comment
[Feature/regressing bug #]: Regression from bug 1197361.
[User impact if declined]: Can get black screenshots shown during newtab images.
[Describe test coverage new/current, TreeHerder]: Mochitests in tree herder, manual tests.
[Risks and why]: Low, this change makes sure we correctly size the thumbnails.
[String/UUID change made/needed]: None
Attachment #8677208 - Flags: approval-mozilla-aurora?
Comment on attachment 8677208 [details] [diff] [review]
Use destination canvas as thumbnail size

Given that this was manually tested, has automated mochitest coverage and has been in Nightly for a few days, let's uplift to Aurora44.
Attachment #8677208 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Depends on: 1231518
Depends on: 1247641
You need to log in before you can comment on or make changes to this bug.