121567 - Page info strict warnings on XML pages

Status: RESOLVED FIXED

(SeaMonkey :: Page Info, defect)

Description

[Boris Zbarsky [:bzbarsky]]

document.links, document.images, document.forms are part of the HTML DOM.  These
are not defined on XML pages....

Not sure what a good way is to get the list of links/images on an XML page; this
is compounded by the fact that these need not correspond to particular tags.

I suggest just checking that |"links" in document| and the like before accessing it.

Comment 1

[sairuh (rarely reading bugmail)]

mass moving open bugs pertaining to page info to [e-mail] as qa contact.

to find all bugspam pertaining to this, set your search string to
"BigBlueDestinyIsHere".

Comment 2

[Daniel Brooks [:db48x]]

Attachment: patch

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 66661 [details] [diff] [review]
patch

Could we do something sane if there is no
document.images or whatever?
e.g. getElementsByTagNameNS?  This should be
doable for images and forms and maybe for links..
(for links, is there a way to take XLink into account?)

Comment 4

[Daniel Brooks [:db48x]]

Attachment: adds sanity

can't do XLinks yet (simple or otherwise) because the treewalker keeps crashing
mozilla.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 68806 [details] [diff] [review]
adds sanity

r=bzbarsky.

If you have a test page for XLinks and test code
that crashes, please mail me those.  I'd like to
get that working.... :)

Comment 6

[Daniel Brooks [:db48x]]

it crashes any time a tree walker goes beyond the end of the document. I had
meant to email a test case to sicking, but I seem to have lost it. I'll recreate
it and email it to you both.

Comment 7

[Alec Flett]

Comment on attachment 68806 [details] [diff] [review]
adds sanity

sr=alecf

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 68806 [details] [diff] [review]
adds sanity

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 9

[Boris Zbarsky [:bzbarsky]]

checked in on the trunk