1215700 - Removing remaining warnings

Status: NEW

(NSS :: Libraries, defect, P3)

Description

[Martin Thomson [:mt:]]

coreconf/WIN32.mk has some classes of warnings disabled.  That isn't good because those warnings can indicate potential bugs.

Here's the current list:

# Disable C4267: conversion from 'size_t' to 'type', possible loss of data
# Disable C4244: conversion from 'type1' to 'type2', possible loss of data
# Disable C4018: 'expression' : signed/unsigned mismatch
# Disable C4312: 'type cast': conversion from 'type1' to 'type2' of greater size

Also, we don't have warnings-as-errors turned on for Android builds.  The same applies there, with some overlap.

We should crush the warnings, then turn on warnings-as-errors.

Of these, some are harder than the others.