1215744 - Unnamed class expressions should not have a .name at all.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Eric Faust [:efaust]]

Attachment: Fix

I believe, from reading the spec, that we missed a piece in bug 1192412, which is that if the class constructor has no name, then we should not set a name at all. I cannot find a call to SetFunctionName that isn't under an "if className is not undefined" condition.

This patch will do that. Modify fun_resolve to just pass on class constructors with no name.

There are three steps, here:

1) Make sure that the default class constructors (which are natives, and never needed to care before) are marked as class constructors.
2) Standardize on fun->atom() == nullptr, including default constructors, which had to use the empty atom because of constraints in the emitter.
3) Teach fun_resolve to skip this case appropriately.

Comment 1

[Eric Faust [:efaust]]

Attachment: Fix with more correct tests

Waldo pointed out that we should make sure that |static name| stuff still works. arai wrote this lovely test for just that, which I had forgotten about. Now with more updates.

Comment 2

[Tooru Fujisawa [:arai]]

Comment on attachment 8675194 [details] [diff] [review]
Fix with more correct tests

Review of attachment 8675194 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you :D

::: js/src/jsfun.cpp
@@ +487,5 @@
>              if (fun->hasResolvedName())
>                  return true;
>  
> +            if (fun->isClassConstructor()) {
> +                // It's impossible to have an empty named class expression. We use empty as a

Comment should be wrapped to 80-chars ;)

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9b9fcad543f3

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/9b9fcad543f3