1215816 - nsContentIterator::Init(nsIDOMRange*) shouldn't include end node if it's an empty element and end offset is 0 when mPre == true

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Similar to bug 1215798, nsContentIterator::Init(nsIDOMRange*) has another bug at deciding the end node of the range.

When the end node is an empty element and the end offset is 0, the iterator shouldn't enumerate the end node. E.g.,

<p>[<br>]<br></p>

At this case, the range is { startNode: first <br>, startOffset: 0, endNode: second <br>, endOffset: 0 }.

With te patch of 1215798, pre-order iterator enumerates both <br> elements in this case.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3a4cef33855e

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: nsContentIterator::Init(nsIDOMRange*) should not include end node if it's an empty element and the end offset is 0 when mPre is true

I'm not sure if you're the best person to review a patch of nsContentIterator, though. See comment 0 for the detail.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c7b56196aaea

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e3232ca40477

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e55d4c56c0ee3bdecef68c73e90ab299a9abbd44
Bug 1215816 nsContentIterator::Init(nsIDOMRange*) should not include end node if it's an empty element and the end offset is 0 when mPre is true r=smaug

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e55d4c56c0ee