1215902 - Fix clang's -Wimplicit-fallthrough warnings in extensions/cookie

Status: RESOLVED FIXED

(Core :: Networking: Cookies, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: MOZ_FALLTHROUGH_extensions-cookie.patch

MOZ_FALLTHROUGH is an annotation to suppress clang's -Wimplicit-fallthrough warnings about switch cases that fall through without a break or return statement. MOZ_FALLTHROUGH is only needed on cases that have code:

switch (foo) {
  case 1: // These cases have no code. No fallthrough annotations are needed.
  case 2:
  case 3:
    foo = 4; // This case has code, so a fallthrough annotation is needed:
    MOZ_FALLTHROUGH;
  default:
    return foo;
}

extensions/cookie/nsCookiePermission.cpp:207:3 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
extensions/cookie/nsPermissionManager.cpp:933:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
extensions/cookie/nsPermissionManager.cpp:952:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
extensions/cookie/nsPermissionManager.cpp:979:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
extensions/cookie/nsPermissionManager.cpp:1061:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
extensions/cookie/nsPermissionManager.cpp:1255:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
extensions/cookie/nsPermissionManager.cpp:1353:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
extensions/cookie/nsPermissionManager.cpp:1377:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels

Comment 1

[Josh Matthews [:jdm]]

Comment on attachment 8675368 [details] [diff] [review]
MOZ_FALLTHROUGH_extensions-cookie.patch

Review of attachment 8675368 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for doing this cleanup!

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0386348c69f5

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0386348c69f5