1215903 - Suppress clang warnings in third-party hunspell code

Status: RESOLVED WONTFIX

(Core :: Spelling checker, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: suppress-hunspell-warnings.patch

extensions/spellcheck/hunspell/src/affentry.cxx:124:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
extensions/spellcheck/hunspell/src/affentry.cxx:551:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
extensions/spellcheck/hunspell/src/affixmgr.cxx:4258:14 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
extensions/spellcheck/hunspell/src/dictmgr.cxx:105:21 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
extensions/spellcheck/hunspell/src/dictmgr.cxx:108:21 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
extensions/spellcheck/hunspell/src/hunspell.cxx:385:6 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
extensions/spellcheck/hunspell/src/hunspell.cxx:455:6 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
extensions/spellcheck/hunspell/src/hunspell.cxx:756:6 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
extensions/spellcheck/hunspell/src/hunspell.cxx:889:11 [-Wimplicit-fallthrough] unannotated fall-through between switch labels

extensions/spellcheck/hunspell/src/hashmgr.hxx:17:21 [-Wunused-private-field] private field 'userword' is not used

extensions/spellcheck/hunspell/src/phonet.cxx:277:21 [-Wunreachable-code] code will never be executed
extensions/spellcheck/hunspell/src/phonet.cxx:277:33 [-Wunreachable-code] code will never be executed

Comment 1

[Nicholas Nethercote [inactive]]

Comment on attachment 8675369 [details] [diff] [review]
suppress-hunspell-warnings.patch

Review of attachment 8675369 [details] [diff] [review]:
-----------------------------------------------------------------

This is third-party code that we periodically update from upstream. If we start trying to ignore warnings in a precise fashion we'll probably have to change the list of ignored warnings next time we update, which isn't useful work.

My intention when I added ALLOW_COMPILER_WARNINGS was that we'd use it unconditionally in directories like this one. I've been considering adding a one-line comment like "Ignore compiler warnings because this is third-party code" above each ALLOW_COMPILER_WARNINGS line like this one.

Comment 2

[Chris Peterson [:cpeterson]]

Fair enough. I will look into upstreaming some fixes.

https://github.com/hunspell/hunspell