1215950 - Crash on Google 2-step verification

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Matt Cosentino]

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:44.0) Gecko/20100101 Firefox/44.0
Build ID: 20151016030228

Steps to reproduce:

Go to google.com
Click sign in
Enter email address
Enter password
Get to 2-step verification page


Actual results:

Crash

Comment 1

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Please post some URLs of these crashlog reports from about:crashes

Comment 2

[Matt Cosentino]

Here are a few:

https://crash-stats.mozilla.com/report/index/bp-7fc685eb-46cb-4d32-8368-459e62151020
https://crash-stats.mozilla.com/report/index/bp-d675c173-14a3-47b0-bb1c-21c6f2151018
https://crash-stats.mozilla.com/report/index/bp-8f4afbca-ccfd-4951-b905-8769f2151018

Comment 3

[Teodora Vermesan (:TeoVermesan)]

I can reproduce the crash everytime with the steps provided on latest Nightly (2015-10-21) using Prestigio PSP5508 (Android 4.4.2)

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Background: This is a regression from the Android 6.0 keyboard workaround (bug 1211848). The crash reports are from Android 6.0 too - that's good. I'm surprised that Teodora can reproduce the crash on an Android 4.4.2 device. I wonder if without the crash the keyboard would not show up too (That's what the workaround fixed).

As mentioned in the duplicate (bug 1216563) I'm going to push the re-focus workaround code to the UI thread.

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: 1215950-refocus-on-ui-thread.patch

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/6c5f530312e3

Comment 8

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8677592 [details] [diff] [review]
1215950-refocus-on-ui-thread.patch

Approval Request Comment

[Feature/regressing bug #]: Regression introduced by bug bug 1216563. Patch in bug 1216563 fixed an issue with the keyboard not showing up on Android 6.0 devices. This fix can lead to a crash. The patch has been uplifted to Aurora (43) and Beta (42).

[User impact if declined]: Potential crash on Android 6 if keyboard should come up.

[Describe test coverage new/current, TreeHerder]: Tested locally on different devices (Android 6, Android 5, Android 2.3).

[Risks and why]: Code logic has not been changed. Instead workaround code is now running on the UI thread (preventing crash on non-UI thread).

[String/UUID change made/needed]: -

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Sebastian, you haven't really answered to the risk question.
Could you explain if it is a risky change or not. Threading changes in beta 10 scare me.

Comment 10

[Sylvestre Ledru [:Sylvestre]]

By the way, the bug in "[Feature/regressing bug #]" is incorrect. This is the duplicate.

Comment 11

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Sylvestre Ledru [:sylvestre] from comment #9)
> Sebastian, you haven't really answered to the risk question.
> Could you explain if it is a risky change or not. Threading changes in beta
> 10 scare me.

I consider it low risk. The normal code flow remains the same. The workaround code is now pushed to the UI thread. This crash is happening because it is not running on the UI thread (it's touching views).

(In reply to Sylvestre Ledru [:sylvestre] from comment #10)
> By the way, the bug in "[Feature/regressing bug #]" is incorrect. This is
> the duplicate.

Oh, sorry. The bug is: bug 1211848 - That's where the regression / this crash has been introduced.

Comment 12

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8677592 [details] [diff] [review]
1215950-refocus-on-ui-thread.patch

OK, Android 6.0 is going more and more popular during the next 6 weeks.
Taking it avoid having do to a dot release. Should be in 42 beta 10.

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/57d711d049c1

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/233ab8d5b962

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6c5f530312e3

Comment 16

[Teodora Vermesan (:TeoVermesan)]

I can't reproduce the crash with the steps provided on latest Nightly (2015-10-26) using Prestigio PSP5508 (Android 4.4.2)

Comment 17

[Matt Cosentino]

I can also confirm that it is working for me now.

Comment 18

[Flaviu Cos]

Verified as fixed in Firefox 42 Beta 10;
Device: Asus Transformer Pad (Android 4.2.1).

Comment 19

[Teodora Vermesan (:TeoVermesan)]

Verified as fixed on Firefox 43.0a2 (2015-10-27)
Device: Prestigio PSP5508 (Android 4.4.2)