Closed Bug 1216038 Opened 9 years ago Closed 9 years ago

eliminate MakeEnumeratedRange's IntType template parameter

Categories

(Core :: MFBT, defect)

Product:
Core
Component:
MFBT
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla44
Tracking Flags:
Tracking Status
firefox44 --- fixed

People

(Reporter: heycam, Assigned: heycam)

References

Details

Attachments

(1 file)

Deduce underlying integer type for MakeEnumeratedRange starting at 0.
1.11 KB, patch
froydnj
: review+
Details | Diff | Splinter Review 
In the one argument version of MakeEnumeratedRange, we can eliminate the IntType template parameter and just deduce how big of an integer type we need for the given EnumType.  Since we're interating from EnumType(0), we know that it's safe to use an unsigned integer type.  (In the future when we can rely on std::underlying_type, we won't need the IntType parameter for the other MakeEnumeratedRange overload, either.)
Assignee: nobody → cam
Status: NEW → ASSIGNED

        Attachment #8675508 -
        Flags: review?(nfroyd)

    
  
Blocks: 1216043

        Attachment #8675508 -
        Flags: review?(nfroyd) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/1f8cd027929b
Status: ASSIGNED → RESOLVED
Closed: 9 years ago

          status-firefox44:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: