1216081 - OscillatorNodeEngine::mFinalFrequency is used uninitialised

Status: RESOLVED FIXED

(Core :: Web Audio, defect)

Description

[Julian Seward [:jseward]]

This might be fallout from bug 1209904.  That introduces the following
fragment

+    if (finalFrequency != mFinalFrequency) {
+      mFinalFrequency = finalFrequency;
+      return true;
+    }

but the problem is that OscillatorNodeEngine::OscillatorNodeEngine
doesn't give an initial value for mFinalFrequency, so the |if| condition
is undefined.

Comparing OscillatorNodeEngine::OscillatorNodeEngine with the list of
fields starting at OscillatorNode.cpp:382, it seems as if it has been
the intention of the constructor to initialise all fields, but that
both mFinalFrequency and mPhaseIncrement were forgotten about.

Comment 1

[Julian Seward [:jseward]]

STR: with an --enable-valgrind --disable-jemalloc build, run

./mach mochitest --valgrind=/usr/bin/valgrind \
   dom/media/webaudio/test/test_delayNodeTailWithDisconnect.html

Comment 2

[Julian Seward [:jseward]]

Attachment: Valgrind complaint

Comment 3

[Julian Seward [:jseward]]

Attachment: Initialise all fields in the constructor of OscillatorNodeEngine

Comment 4

[Paul Adenot (:padenot)]

Comment on attachment 8675590 [details] [diff] [review]
Initialise all fields in the constructor of OscillatorNodeEngine

Review of attachment 8675590 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks !

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4aa9e709ddf7

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4aa9e709ddf7