Closed
Bug 1216085
Opened 9 years ago
Closed 9 years ago
(Gaia RTL 2.5) [emergency-call] CSS refactoring
Categories
(Firefox OS Graveyard :: Gaia::Dialer, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
FxOS-S10 (30Oct)
People
(Reporter: autra, Assigned: autra)
References
Details
Attachments
(1 file)
BiDi CSS refactoring for emergency-call app.
|
Assignee | |
Updated•9 years ago
|
Blocks: CSS_Refactor_2.5, 1181927
|
|
Assignee | |
Updated•9 years ago
|
QA Contact: augustin.trancart
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → augustin.trancart
QA Contact: augustin.trancart
|
||
Comment 1•9 years ago
|
||
|
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8675597 [details] [review] [gaia] Phoxygen:bug1216085-emergency-call_rtl_refactoring > mozilla-b2g:master This patch refactor the CSS for rtl support. It mainly removes the need to do a scaleX by using gaia-icons. As a result, there is a small visual difference after this patch: the arrow is slightly thicker. On the other hand, we are now more consistent with the rest of the system (eg with settings for example) and we'll stay so more easily.
Attachment #8675597 -
Flags: review?(gsvelto)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8675597 [details] [review] [gaia] Phoxygen:bug1216085-emergency-call_rtl_refactoring > mozilla-b2g:master (In reply to Augustin Trancart [:autra] from comment #2) > As a result, there is a small visual difference after this patch: the arrow > is slightly thicker. On the other hand, we are now more consistent with the > rest of the system (eg with settings for example) and we'll stay so more > easily. +1 for consistency, looking good.
Attachment #8675597 -
Flags: review?(gsvelto) → review+
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
|
||
Comment 4•9 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/3b4cd4e69f655867f23239c2b438e552358e409e
Status: NEW → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S10 (30Oct)
You need to log in
before you can comment on or make changes to this bug.
Description
•