Closed Bug 1216109 Opened 9 years ago Closed 8 years ago

Enable SHA-2 test for the WebCrypto API's PBKDF2 implementation

Categories

(Core :: DOM: Security, defect)

Product:
Core
Component:
DOM: Security
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla47
Tracking Flags:
Tracking Status
firefox47 --- fixed
relnote-firefox --- 47+

People

(Reporter: ttaubert, Assigned: ttaubert)

References

Details

Attachments

(1 file)

0001-Bug-1216109-Enable-SHA-2-test-for-the-WebCrypto-API-.patch
1.67 KB, patch
mt
: review+
Details | Diff | Splinter Review 
Once bug 554827 is ready we can enable the test I wrote when I landed PBKDF2.
Assignee: nobody → ttaubert
Status: NEW → ASSIGNED
This needs to wait until bug 554827 hits m-c but it doesn't hurt to review the patch in the meantime :)
Attachment #8688390 - Flags: review?(martin.thomson)
Attachment #8688390 - Flags: review?(martin.thomson) → review+
Depends on: 1228410
https://hg.mozilla.org/mozilla-central/rev/550ee89ba040
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Target Milestone: mozilla46 → mozilla47
Release Note Request (optional, but appreciated)
[Why is this notable]: We exposed PBKDF2 via our WebCrypto implementation a while ago but did not support hash algorithms other than SHA-1. I think devs would rather want to use SHA-2 hash functions.
[Suggested wording]: WebCrypto: PBKDF2 supports SHA-2 hash algorithms
[Links (documentation, blog post, etc)]:
relnote-firefox: --- → ?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: