1216222 - Create an end-to-end test that verifies the SMS report shows coherent information

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Johan Lorenzo [:jlorenzo]]

Steps for this test:
1. Open SMS
2. Create a new message that you send to your self
3. Wait until the message is received
4. On both sent and received message, open the report and check that:
* the type of message is the right one
* the times and dates are coherent (±1 minute)
* the sender/receiver is the right one.

I just noticed we don't have a Moztrap test for it. Could you create one, Isabel?

Comment 1

[Martijn Wargers (dead)]

We already have a similar test like that, no?

Comment 2

[Johan Lorenzo [:jlorenzo]]

The send/receive SMS part already exist is some of our tests. I didn't find anything about the SMS report, though. What test are you thinking of?

Comment 3

[Martijn Wargers (dead)]

I was thinking of this test:
http://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/tests/functional/messages/test_sms.py

I guess it could be enhanced to include the things that are mentioned in comment 0, or is that not allowed?

Comment 4

[Johan Lorenzo [:jlorenzo]]

As test_sms.py is a part of the smoketests and checking the report is not. I think it's better to have 2 different tests, for now.

Comment 5

[Isabel Rios[:isabel_rios]]

Attachment: Pull request

Comment 6

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8680135 [details] [review]
Pull request

That pull request looks fine to me. One small thing I forgot to mention before, these files are not necessary:
* tests/python/gaia-ui-tests/gaiatest/tests/functional/__init__.py
* tests/python/gaia-ui-tests/gaiatest/tests/functional/messages/__init__.py

There's more detail about them in the PR.

Congratulations for your first test!

Comment 7

[Martijn Wargers (dead)]

Comment on attachment 8680135 [details] [review]
Pull request

Some nits you could fix, but it all looks good in general.
I think you need to remove these files from the pull request, though:
tests/python/gaia-ui-tests/gaiatest/tests/functional/messages/__init__.py
tests/python/gaia-ui-tests/gaiatest/tests/functional/__init__.py

I also think class Report should be a PageRegion, but since we don't do in many more places, I don't think it matters much, currently.
I filed bug 1216626 to do all these files at some point in time.

Comment 8

[Isabel Rios[:isabel_rios]]

Thank you Johan, Martijn! 
Agree, those files where created for defining the test one way that was not the correct one and so never used again. Will remove them.

Comment 9

[GitHub Autolander Bot]

Attachment: [gaia] isabelrios:test_report > mozilla-b2g:master

Comment 10

[Isabel Rios[:isabel_rios]]

It was not merged yet, so re-opening

Comment 11

[Isabel Rios[:isabel_rios]]

Merged in master: https://github.com/mozilla-b2g/gaia/commit/173c8ca4c1c68a7ba882e9d8fda10d1a8fa0e7a4

Comment 12

[Isabel Rios[:isabel_rios]]

I just realized I did not created the test in Moztrap for this :( 
Added it now: https://moztrap.mozilla.org/manage/cases/?filter-id=17818

In which suite should it be? Not sure whether I should add some tags to it.

Comment 13

[Johan Lorenzo [:jlorenzo]]

IMO, it should belong to the Message suite[1], the Delivery report one[2] and the small set of message[3]. The small set seems important to cover as we don't have no test checking this area, IIRC.


[1] https://moztrap.mozilla.org/manage/cases/?filter-suite=210
[2] https://moztrap.mozilla.org/manage/cases/?filter-suite=497
[3] https://moztrap.mozilla.org/manage/cases/?filter-suite=687