Closed Bug 1216265 Opened 4 years ago Closed 4 years ago

Remove any telemetry probes that reveal a user has entered private browsing

Categories

(Firefox for Android :: General, defect)

35 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 44
Tracking Status
firefox42 --- fixed
firefox43 --- fixed
firefox44 --- fixed

People

(Reporter: Margaret, Assigned: Margaret)

References

Details

Attachments

(2 files)

No description provided.
Bug 1216265 - Only record tracking protection telemetry in non-private tabs. r?mfinkle
Attachment #8675847 - Flags: review?(mark.finkle)
Comment on attachment 8675847 [details]
MozReview Request: Bug 1216265 - Only record tracking protection telemetry in non-private tabs. r?mfinkle

https://reviewboard.mozilla.org/r/22463/#review20033

OK. This patch changes Firefox to only track TP in normal browsing. Someday, when we support TP in normal and private browsing, we should re-evaluate the tracking, since you won't be able to distingush which mode the user is in, only that they are using TP.
Attachment #8675847 - Flags: review?(mark.finkle) → review+
From the UI Telemetry dash board I see:
actionbar > new_private_tab
contextmenu > home_open_private_tab
contextmenu > web_open_private_tab
menu > close_private_tabs
menu > new_private_tab

This patch converts those actions to the non-private version. We are unable to tell if the user is entering (or closing) a private browsing session or a normal session.
Attachment #8675869 - Flags: review?(margaret.leibovic)
Comment on attachment 8675869 [details] [diff] [review]
privatebrowsing-uitelemetry-collapse v0.1

Review of attachment 8675869 [details] [diff] [review]:
-----------------------------------------------------------------

Do we also want to get rid of this "hint-private-browsing" probe?
http://hg.mozilla.org/mozilla-central/annotate/1a157155a4fe/mobile/android/base/home/HistoryPanel.java#l363

::: mobile/android/base/tabs/TabsPanel.java
@@ +192,5 @@
>          if (mCurrentPanel == Panel.NORMAL_TABS) {
>              Telemetry.sendUIEvent(TelemetryContract.Event.ACTION, TelemetryContract.Method.ACTIONBAR, "new_tab");
>              mActivity.addTab();
>          } else {
> +            Telemetry.sendUIEvent(TelemetryContract.Event.ACTION, TelemetryContract.Method.ACTIONBAR, "new_tab");

Nit: we could move this outside the if/else to reduce redundancy.
Attachment #8675869 - Flags: review?(margaret.leibovic) → review+
(In reply to Mark Finkle (:mfinkle) from comment #2)
> Comment on attachment 8675847 [details]
> MozReview Request: Bug 1216265 - Only record tracking protection telemetry
> in non-private tabs. r?mfinkle
> 
> https://reviewboard.mozilla.org/r/22463/#review20033
> 
> OK. This patch changes Firefox to only track TP in normal browsing. Someday,
> when we support TP in normal and private browsing, we should re-evaluate the
> tracking, since you won't be able to distingush which mode the user is in,
> only that they are using TP.

For the record, I modeled this after what the desktop code does for these histograms.
https://hg.mozilla.org/integration/fx-team/rev/ec827f7f696609385dceedda593c653725e61d35
Bug 1216265 - Only record tracking protection telemetry in non-private tabs. r=mfinkle
(In reply to :Margaret Leibovic from comment #4)
> Comment on attachment 8675869 [details] [diff] [review]
> privatebrowsing-uitelemetry-collapse v0.1
> 
> Review of attachment 8675869 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Do we also want to get rid of this "hint-private-browsing" probe?
> http://hg.mozilla.org/mozilla-central/annotate/1a157155a4fe/mobile/android/
> base/home/HistoryPanel.java#l363

No. It only opens the menu, showing the New Tab and New Private Tab menu actions.
https://hg.mozilla.org/mozilla-central/rev/ec827f7f6966
https://hg.mozilla.org/mozilla-central/rev/a32793e98926
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Comment on attachment 8675847 [details]
MozReview Request: Bug 1216265 - Only record tracking protection telemetry in non-private tabs. r?mfinkle

Approval Request Comment
[Feature/regressing bug #]: Private Browsing 2.0

[User impact if declined]: We'll collect telemetry data that indicates a user has used private browsing, and we don't want to do that.

[Describe test coverage new/current, TreeHerder]: No automated tests, landed on mozilla-central.

[Risks and why]: Low-risk change to telemetry probes. The main risk is that our telemetry data could be screwed up, but that won't be a user-facing problem.

[String/UUID change made/needed]: None.
Attachment #8675847 - Flags: approval-mozilla-beta?
Attachment #8675847 - Flags: approval-mozilla-aurora?
Attachment #8675869 - Flags: approval-mozilla-beta?
Attachment #8675869 - Flags: approval-mozilla-aurora?
Comment on attachment 8675847 [details]
MozReview Request: Bug 1216265 - Only record tracking protection telemetry in non-private tabs. r?mfinkle

Anything to improve our decision process, taking it.
Should be in 42 beta 10
Attachment #8675847 - Flags: approval-mozilla-beta?
Attachment #8675847 - Flags: approval-mozilla-beta+
Attachment #8675847 - Flags: approval-mozilla-aurora?
Attachment #8675847 - Flags: approval-mozilla-aurora+
Sylvestre: for uplifting are you planning to give both patches a a+ or only the one that have already a+ ?
Flags: needinfo?(sledru)
Comment on attachment 8675869 [details] [diff] [review]
privatebrowsing-uitelemetry-collapse v0.1

Yes, sorry, my bad.
Flags: needinfo?(sledru)
Attachment #8675869 - Flags: approval-mozilla-beta?
Attachment #8675869 - Flags: approval-mozilla-beta+
Attachment #8675869 - Flags: approval-mozilla-aurora?
Attachment #8675869 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.