Closed Bug 1216273 Opened 9 years ago Closed 9 years ago

Intermittent media_playback_test.js | media playback tests could pull the tray

Categories

(Firefox OS Graveyard :: Gaia::System::Music Control, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(feature-b2g:2.6+)

RESOLVED FIXED
feature-b2g 2.6+

People

(Reporter: KWierso, Assigned: mikehenrty)

References

Details

(Keywords: intermittent-failure, Whiteboard: [systemsfe] [MJS] [intermittents])

Attachments

(1 file)

Assignee: nobody → mhenretty
Blocks: 1222215
Whiteboard: [systemsfe]
The problem is that the media_playback_actions library does a findElement, then a check for `displayed` when manipulating the utility tray gripper. However, when the utility tray is bouncing (ie. overscrolle), gecko marks the grippy as not displayed and so `display()` will return false for that split second during the bounce. This makes the media_playback_actions library throw an excpetion. More robust would be to do a waitForElement, which will findElement and then do a waitFor until it is displayed.
Comment on attachment 8684889 [details] [review]
[gaia] mikehenrty:bug-1216273-wait-for-element-media-playback > mozilla-b2g:master

I'm not seeing the media_playback test failure anymore [1]. I think this one is fixed. Greg, can you have a look?

1.) https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=b88c8b5aa5b36b9289df3695b04df22bf0eee263
Attachment #8684889 - Flags: review?(gweng)
Comment on attachment 8684889 [details] [review]
[gaia] mikehenrty:bug-1216273-wait-for-element-media-playback > mozilla-b2g:master

Thanks for digging and patching it. It really helps!
Attachment #8684889 - Flags: review?(gweng) → review+
master: https://github.com/mozilla-b2g/gaia/commit/a0bb424a9dfaf8fafeafc98e8019fb6f1418a51e
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
FWIW, those failures could be caused by the fact we aren't running the latest gaia in Gij (bug 1225465). Let's keep an eye on this after that fix lands.
feature-b2g: --- → 2.6+
Whiteboard: [systemsfe] → [systemsfe] [MJS]
Haven't seen this one for a few months, I think bug 1225465 was giving us false negatives. Re-closing.
Status: REOPENED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
Whiteboard: [systemsfe] [MJS] → [systemsfe] [MJS] [intermittents]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: