Closed
Bug 1216273
Opened 9 years ago
Closed 9 years ago
Intermittent media_playback_test.js | media playback tests could pull the tray
Categories
(Firefox OS Graveyard :: Gaia::System::Music Control, defect)
Firefox OS Graveyard
Gaia::System::Music Control
ARM
Gonk (Firefox OS)
Tracking
(feature-b2g:2.6+)
RESOLVED
FIXED
feature-b2g | 2.6+ |
People
(Reporter: KWierso, Assigned: mikehenrty)
References
Details
(Keywords: intermittent-failure, Whiteboard: [systemsfe] [MJS] [intermittents])
Attachments
(1 file)
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Updated•9 years ago
|
Assignee | ||
Comment 5•9 years ago
|
||
The problem is that the media_playback_actions library does a findElement, then a check for `displayed` when manipulating the utility tray gripper. However, when the utility tray is bouncing (ie. overscrolle), gecko marks the grippy as not displayed and so `display()` will return false for that split second during the bounce. This makes the media_playback_actions library throw an excpetion. More robust would be to do a waitForElement, which will findElement and then do a waitFor until it is displayed.
Comment 6•9 years ago
|
||
Assignee | ||
Comment 7•9 years ago
|
||
Comment on attachment 8684889 [details] [review]
[gaia] mikehenrty:bug-1216273-wait-for-element-media-playback > mozilla-b2g:master
I'm not seeing the media_playback test failure anymore [1]. I think this one is fixed. Greg, can you have a look?
1.) https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=b88c8b5aa5b36b9289df3695b04df22bf0eee263
Attachment #8684889 -
Flags: review?(gweng)
Comment 8•9 years ago
|
||
Comment on attachment 8684889 [details] [review]
[gaia] mikehenrty:bug-1216273-wait-for-element-media-playback > mozilla-b2g:master
Thanks for digging and patching it. It really helps!
Attachment #8684889 -
Flags: review?(gweng) → review+
Assignee | ||
Comment 9•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment hidden (Intermittent Failures Robot) |
Updated•9 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 11•9 years ago
|
||
FWIW, those failures could be caused by the fact we aren't running the latest gaia in Gij (bug 1225465). Let's keep an eye on this after that fix lands.
Updated•9 years ago
|
feature-b2g: --- → 2.6+
Updated•9 years ago
|
Whiteboard: [systemsfe] → [systemsfe] [MJS]
Assignee | ||
Comment 12•9 years ago
|
||
Haven't seen this one for a few months, I think bug 1225465 was giving us false negatives. Re-closing.
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
Updated•9 years ago
|
Whiteboard: [systemsfe] [MJS] → [systemsfe] [MJS] [intermittents]
You need to log in
before you can comment on or make changes to this bug.
Description
•