1216312 - Remove unused icon_shareplane

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

To start, set up a build environment - you can see the instructions here: https://wiki.mozilla.org/Mobile/Fennec/Android

Then, you'll need to create a patch to upload - see
https://wiki.mozilla.org/Mobile/Fennec/Android#Creating_commits_and_submitting_patches

To fix this bug, run `hg rm <file>` on the unused assets called icon_shareplane.png [1].

If you need any help, you can reply to this bug, or feel free to message me on IRC - my nick is "mcomella" and you can find me in #mobile. If you need IRC setup instructions, see https://wiki.mozilla.org/IRC

Thanks and happy coding! ^_^

[1]: http://mxr.mozilla.org/mozilla-central/find?text=&string=icon_shareplane

Comment 1

[Manav Batra]

Attachment: Removed unused icon_shareplane

Hey,

I think I've followed the steps correctly.
Please review the patch.

Thanks.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Hey, Manav!

Thanks for the patch! Unfortunately, our test servers are down at the moment so we can't push the patch via our usual processes. Once they get back up, I'll push this to the test servers and we'll get going again!

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=21e6b75b98ba

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8676440 [details] [diff] [review]
Removed unused icon_shareplane

Review of attachment 8676440 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me!

I made a push to our try test servers (above).

Once the push goes green, you can add the "checkin-needed" keyword [1] to get your patch checked in. Note that all patches added via checkin-needed keyword need an associated green try run. Let me know if you need help reading the results.

[1]: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_checked_into_the_tree

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Since this is inactive, this is to be fixed in bug 1210989.

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Since we backed out the bug 1140048 that added this bug, this does not affect any versions until bug 1140048 lands again.

Comment 7

[:Margaret Leibovic]

In that case, I think we should just fix this as part of an updated patch for bug 1140048.

Comment 8

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

I'd like to leave this open so we don't forget to do it as part of bug 1140048.

Comment 9

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.