1216328 - Menu height definition is unintuitively overridden dynamically

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

And perhaps several times.

tldr; improve the readability of the menu height definition.

I was trying to fix bug 1213486 but it was difficult to set a maximum height for each menu item – the shareplane view is a MenuItemActionBar from GeckoMenuItem.getActionView, called from GeckoMenu.addActionItem. It is then constrained by it's parent view, mSecondaryActionItemBar, which may be constrained by the GeckoListView it's in. Things to try changing (I tried some):
  * Changing the styles of Widget.MenuItem*ActionBar (it should be SecondaryActionBar afaict)
  * Changing the styles inherited by mSecondaryActionItemBar
  * Changing the styles of the containing ListView

Changing menu item height should be simple change but it's really hard – it should be defined in a centralized XML file and never overridden – that's the goal with this bug.

Comment 1

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.