1216344 - Remove the usage of TelemetryWrapper

Status: RESOLVED DUPLICATE of bug 1308337

(Firefox for Android Graveyard :: Android Sync, defect)

Description

[Ahmed Khalil]

Remove the usage of TelemetryWrapper[1], and replace it with the Telemetry[2] class directly.


[1] https://dxr.mozilla.org/mozilla-central/source/mobile/android/stumbler/java/org/mozilla/mozstumbler/service/utils/TelemetryWrapper.java

[2] https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/Telemetry.java?case=true&from=Telemetry.java

Comment 1

[Richard Newman [:rnewman]]

Last I checked, the code in mobile/android/stumbler is shared with the standalone MozStumbler app. That's why it uses reflection here to access telemetry.

https://github.com/mozilla/MozStumbler/

It looks like MozStumbler is still in active development, so we shouldn't diverge here in-tree. Indeed, someone should take ownership of this and make sure we track mainline…

What's going on, Nick?

Comment 2

[Nick Alexander :nalexander [he/him]]

(In reply to Richard Newman [:rnewman] from comment #1)
> Last I checked, the code in mobile/android/stumbler is shared with the
> standalone MozStumbler app. That's why it uses reflection here to access
> telemetry.

I wasn't aware of this: https://github.com/mozilla/MozStumbler/commit/af7d7d2e930f7def8b1240e236be55854d55c485.

> It looks like MozStumbler is still in active development, so we shouldn't
> diverge here in-tree. Indeed, someone should take ownership of this and make
> sure we track mainline…

Ah, the joys of upstream maintainence.
 
> What's going on, Nick?

Victor, is it worth your time to update the Fennec version of MozStumbler?  Better data, new formats, anything?

Comment 3

[Victor Ng [:vng] [:crankycoder]]

The code in Fennec is a snapshot of the stumbler code at one point in time.  :rnewman is correct - the TelemetryWrapper exists because the standard Android stumbler doesn't use telemetry.

Since the time that the stumbler code was integrated into Fennec, I've pulled out all the non-UI related code into a library.  The plan is to eventually get the library into an unbound service eventually.  I'd like to rip out the stumbler code from Fennec and reduce it down to just the wifi scan code. 

The changes we've made to the Android stumbler are mostly related to the UI.  There are no new data streams that are relevant to the core stumbling feature.

tl;dr - Let's just remove the TelemetryWrapper and go with the regular Telemetry class in the Fennec source for now.

Comment 4

[u563752]

Hello,
I'm new to the community and looking for a first, can I get some informations how to start with this bug ? 
Thank you !

Comment 5

[Nick Alexander :nalexander [he/him]]

(In reply to Mouaad from comment #4)
> Hello,
> I'm new to the community and looking for a first, can I get some
> informations how to start with this bug ? 
> Thank you !

Hi Mouaad -- thanks for your interest, but I was just looking at the details here and there's a dependency between the stumbler and the main code that makes this tricky.  Would you mind looking for a different ticket?  Thanks!

Comment 6

[:Grisha Kruglov]

This is likely going to happen as part of the new sync ping.