1216350 - Tablet favicon is busted and upside-down

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Chenxia Liu [:liuche]]

Attachment: Screenshot: Tablet tab favicons are wrong

See screenshot, on Nightly 44 10/19, Nexus 7.

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Bisect says the regressing commit is b2fb2a45b780:
https://hg.mozilla.org/integration/fx-team/rev/b2fb2a45b780

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

fwiw, the change of the favicon view from ImageView to ImageButton was the only relevant change I saw:
  https://hg.mozilla.org/integration/fx-team/diff/b2fb2a45b780/mobile/android/base/resources/layout-large-v11/tab_strip_item_view.xml

Comment 4

[Jonathan Almeida [:jonalmeida]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6a36b53c47ba

Comment 5

[Jonathan Almeida [:jonalmeida]]

Changing the ImageView to a button was a mistake (it was related to testing failing with a button, but might not be the case anymore). Changed it back and will wait for the try build to verify if the robocop test still works.

Sorry about that!

Comment 6

[Jonathan Almeida [:jonalmeida]]

Attachment: MozReview Request: Bug 1216350 - Tablet favicon is busted and upside-down r?mcomella

Bug 1216350 - Tablet favicon is busted and upside-down r?mcomella

Comment 7

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8676485 [details]
MozReview Request: Bug 1216350 - Tablet favicon is busted and upside-down r?mcomella

https://reviewboard.mozilla.org/r/22733/#review20277

I can only speculate on why this caused the favicon to appear upside-down (it adds some button-style padding causing overflow and strangeness) but if it works for you, it works for me!

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/e06172c923ac

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e06172c923ac

Comment 10

[Flaviu Cos]

Verified as fixed in build 44.0a1 2015-10-22;
Device: Asus Transformer Pad (Android 4.2.1).