Closed
Bug 1216350
Opened 10 years ago
Closed 10 years ago
Tablet favicon is busted and upside-down
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox44 verified, fennec44+)
VERIFIED
FIXED
Firefox 44
People
(Reporter: liuche, Assigned: jonalmeida)
References
Details
(Keywords: regression)
Attachments
(2 files)
Screenshot: Tablet tab favicons are wrong
See screenshot, on Nightly 44 10/19, Nexus 7.
|
||
Comment 2•10 years ago
|
||
Bisect says the regressing commit is b2fb2a45b780:
https://hg.mozilla.org/integration/fx-team/rev/b2fb2a45b780
Blocks: 1174366
Flags: needinfo?(jonalmeida942)
|
|
||
Updated•10 years ago
|
Keywords: regression
fwiw, the change of the favicon view from ImageView to ImageButton was the only relevant change I saw:
https://hg.mozilla.org/integration/fx-team/diff/b2fb2a45b780/mobile/android/base/resources/layout-large-v11/tab_strip_item_view.xml
|
|
||
Updated•10 years ago
|
tracking-fennec: --- → ?
|
Assignee | |
Comment 4•10 years ago
|
||
|
|
Assignee | |
Comment 5•10 years ago
|
||
Changing the ImageView to a button was a mistake (it was related to testing failing with a button, but might not be the case anymore). Changed it back and will wait for the try build to verify if the robocop test still works.
Sorry about that!
Flags: needinfo?(jonalmeida942)
|
|
Assignee | |
Comment 6•10 years ago
|
||
Bug 1216350 - Tablet favicon is busted and upside-down r?mcomella
Attachment #8676485 -
Flags: review?(michael.l.comella)
Attachment #8676485 -
Flags: review?(michael.l.comella) → review+
Comment on attachment 8676485 [details]
MozReview Request: Bug 1216350 - Tablet favicon is busted and upside-down r?mcomella
https://reviewboard.mozilla.org/r/22733/#review20277
I can only speculate on why this caused the favicon to appear upside-down (it adds some button-style padding causing overflow and strangeness) but if it works for you, it works for me!
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
|
||
Comment 9•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
|
|
||
Updated•10 years ago
|
Assignee: nobody → jonalmeida942
|
||
Updated•10 years ago
|
tracking-fennec: ? → 44+
|
||
Comment 10•10 years ago
|
||
Verified as fixed in build 44.0a1 2015-10-22;
Device: Asus Transformer Pad (Android 4.2.1).
Status: RESOLVED → VERIFIED
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•