Closed Bug 1216350 Opened 6 years ago Closed 6 years ago
Tablet favicon is busted and upside-down
See screenshot, on Nightly 44 10/19, Nexus 7.
Bisect says the regressing commit is b2fb2a45b780: https://hg.mozilla.org/integration/fx-team/rev/b2fb2a45b780
fwiw, the change of the favicon view from ImageView to ImageButton was the only relevant change I saw: https://hg.mozilla.org/integration/fx-team/diff/b2fb2a45b780/mobile/android/base/resources/layout-large-v11/tab_strip_item_view.xml
Changing the ImageView to a button was a mistake (it was related to testing failing with a button, but might not be the case anymore). Changed it back and will wait for the try build to verify if the robocop test still works. Sorry about that!
Bug 1216350 - Tablet favicon is busted and upside-down r?mcomella
Attachment #8676485 - Flags: review?(michael.l.comella)
Attachment #8676485 - Flags: review?(michael.l.comella) → review+
Comment on attachment 8676485 [details] MozReview Request: Bug 1216350 - Tablet favicon is busted and upside-down r?mcomella https://reviewboard.mozilla.org/r/22733/#review20277 I can only speculate on why this caused the favicon to appear upside-down (it adds some button-style padding causing overflow and strangeness) but if it works for you, it works for me!
Verified as fixed in build 44.0a1 2015-10-22; Device: Asus Transformer Pad (Android 4.2.1).
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.