1216368 - UI Showcase, Panel views not showing correct view

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect)

Description

[David Critchley (:dcritch)]

Attachment: Incorrect View in UI Showcase for Room List

In PanelView within UI Showcase, some views are incorrect.  See screenshot for an example. They seem to be displaying the Hello homepage only.

Comment 1

[Ed Lee :Mardak]

Regressed by bug 1212079.

Standard8 noticed the return value of getLoopPref was removed.

https://hg.mozilla.org/integration/fx-team/rev/5bf43b7a4e7b#l19.119

Comment 2

[David Critchley (:dcritch)]

Attachment: Attachment to Bug 1216368 - UI Showcase, Panel views not showing correct view

Fixing fake-Mozloop, missing return on function

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/a8b183936c65

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a8b183936c65

Comment 5

[Bogdan Maris, Desktop QA]

Maybe a dumb question but can you please explain or show what the issue was?
Looking at the screenshot attached, I don't seem to figure out the initial issue in order to verify that was fixed.

Comment 6

[David Critchley (:dcritch)]

(In reply to Bogdan Maris, QA [:bogdan_maris] from comment #5)
> Maybe a dumb question but can you please explain or show what the issue was?
> Looking at the screenshot attached, I don't seem to figure out the initial
> issue in order to verify that was fixed.

The UI Showcase, that we use for testing/displaying all views within Hello, was displaying what was shown in the screenshot, for all the panel views. If you look at the screenshot, the title for each of those views indicates the page should be the Room List, however, it was showing the Hello homepage for those views. This was the issue for all of the panel views in the UI Showcase, with exception of the first one, which is supposed to show the Hello homepage. I will attach a screenshot of what the UI Showcase - Rooms List panel view is to look like.

Comment 7

[David Critchley (:dcritch)]

Attachment: What UI Showcase Rooms List should look like

Comment 8

[Mark Banner (:standard8)]

This is developer/test-only code so doesn't need verification.